Uh oh!
There was an error while loading. Please reload this page.
assets-controllers: Remove AllowedActions, AllowedEvents - #4344
Merged
mcmire merged 2 commits intoMay 31, 2024
Conversation
These types were mistakenly exported in a previous commit when converting NftDetectionController to BaseController v2. They can still be exports in `NftDetectionController.ts`, but just not be exports from the perspective of the whole `assets-controllers` package. This commit takes these exports away by replacing the `*` export in `index.ts` with explicit names and ensures not to include the two aforementioned types.
mcmire
commented
May 30, 2024
| } from './NftController'; | ||
| export { getDefaultNftControllerState, NftController } from './NftController'; | ||
| export * from './NftDetectionController'; | ||
| export type { |
CollaboratorAuthor
There was a problem hiding this comment.
To review this, look through NftDetectionController.ts and make sure that we are listing all exports there minus AllowedActions and AllowedEvents.
bergeron
approved these changes
May 31, 2024
bergeron
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I see everything exported in NftDetectionController.ts included here
mcmire
deleted the
remove-allowed-events-and-actions-for-nft-detection-controller
branch
May 31, 2024 03:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
These types were mistakenly exported in a previous commit when converting NftDetectionController to BaseController v2. They can still be exports in
NftDetectionController.ts, but just not be exports from the perspective of the wholeassets-controllerspackage. This commit takes these exports away by replacing the*export inindex.tswith explicit names and ensures not to include the two aforementioned types.References
This is a followup to #4312.
Changelog
The changelog in #4342 already does not mention the existence of these two exports, so nothing should need to be done.
Checklist