Release 158.0.0 by mcmire · Pull Request #4342 · MetaMask/core

mcmire · 2024-05-30T18:09:05Z

Explanation

The goal of this PR is to release any changes in packages that have not yet been released. This is a prerequisite to merging #3611.

Hence, this PR includes releases for most packages.

References

As stated above, this is a prerequisite to #3611.

Changelog

(N/A)

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

mcmire · 2024-05-30T19:53:47Z

Pinging relevant parties that have code ownership over or have made direct changes to the packages being released here:

@ccharly @montelaidev (see accounts-controller)
@jiexi (see polling-controller)
@infiniteflower @OGPoyraz (see preferences-controller)
@BZahory (see user-operation-controller)

Please look over the changelog entries for the packages mentioned above, cross-reference them against the PRs mentioned in the changelog entries, and let me know if there are any discrepancies.

mcmire · 2024-05-30T20:28:27Z

Looks like #4310 was just merged. I'll try to incorporate those changes into the changelog tonight.

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

mcmire · 2024-05-30T23:00:07Z

#4319 was also merged and I will work on incorporating this as well.

legobeat · 2024-05-30T23:00:41Z

Do you think we could consider #4335 for this as well?

mcmire · 2024-05-30T23:01:43Z

@legobeat Yeah, those changes seem pretty easy to add.

legobeat

lgtm

dbrans · 2024-05-31T14:17:35Z

@mcmire would you be willing to include #4343 which I just merged?

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

) ## Explanation This pull request adds two new methods `getSelectedMultichainAccount`, `listMultichainAccounts` and `selectedEvmAccountChange` event. The optional arguments are to make the changes backwards compatible when used with evm specific controllers. ## References Related to: - [381](MetaMask/accounts-planning#381) - [419](MetaMask/accounts-planning#419) ## Changelog ### `@metamask/accounts-controller` - **<CHANGED>**: Adds two new methods `getSelectedMultichainAccount`, `listMultichainAccounts`, and `selectedEvmAccountChange` event ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

… the transaction (#4343) > [!NOTE] > This change is intended to be cherry-picked into MetaMask/extension v11.17.0 via an upgrade to the @metamask/transaction-controller package. ## Explanation **Issue:** A recent update to the transaction-controller has made the TransactionMeta object passed to the `afterSign` hook frozen. This change prevents adding new properties, leading to the error: “Cannot add property custodyId, object is not extensible.” This bug is breaking all transactions for MMI as the original txMeta cannot store required properties like custodyId. **Fix:** We deep clone the transaction meta before passing it to the hook. A deep clone is used because transactionMeta is recursively frozen by immer. This fix was intended to minimize the change for the cherry-pick going into v11.17.0. A longer term solution might involve using immer more throughout the TransactionController.ts file to make it clearer when a transactionMeta is being mutated and how. **Testing:** This fix was applied to and verified with the MMI extension.  ## References  ## Changelog  ### `@metamask/transaction-controller` - **FIXED**: afterSign hook is now able to modify the transaction ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate

## Explanation Adds 2 query parameters when fetching token lists: - `includeERC20Permit=false` - `includeStorage=false` The best I can tell, neither field is used by extension or mobile. So we'll instead take the reduction in network usage (~5KB on mainnet) and controller state. ## References https://consensyssoftware.atlassian.net/browse/API-1186 ## Changelog ### `@metamask/assets-controllers` - **BREAKING**: `TokenListController` no longer includes the fields `storage` and `erc20Permit` in its state. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate

mcmire · 2024-05-31T15:59:22Z

Okay I think we're up to date with main! Ready for final approval again.

cryptodev-2s

LGTM!

mcmire · 2024-05-31T16:11:14Z

I'm gonna pull the trigger on this before any other changes get added :)

This reverts commit c2e6752.

This reverts commit c2e6752. We need to redo this release because the version set in `package.json` was wrong and therefore the release did not go out. 🤦🏻

This is a redo of commit c2e6752, which did not result in a release because it did not update the version of the root package. This commit fixes that. The remainder of this description was copied from that commit: The goal of this PR is to release any changes in packages that have not yet been released. This is a prerequisite to upgrading all packages to Node 18. Hence, this PR includes releases for most packages. See updates to changelogs for more. --------- Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com> Co-authored-by: Monte Lai <monte.lai@consensys.net> Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net> Co-authored-by: Derek Brans <dbrans@gmail.com> Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>

mcmire force-pushed the release/158.0.0 branch 4 times, most recently from 4e7680c to 55504edCompare May 30, 2024 19:42

mcmire marked this pull request as ready for review May 30, 2024 19:42

mcmire requested a review from a team as a code owner May 30, 2024 19:42

mcmire requested a review from a teamMay 30, 2024 19:42

Release 158.0.0
868c871

mcmire force-pushed the release/158.0.0 branch from 55504ed to 868c871Compare May 30, 2024 19:45

Update some peer dependencies
012d5b9

mcmire mentioned this pull request May 30, 2024
Remove recent peer dependency bumps #4338
Closed
3 tasks

MajorLift reviewed May 30, 2024
View reviewed changes

Comment threadpackages/composable-controller/CHANGELOG.md

Update ComposableController changelog
fc94a75
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

MajorLift mentioned this pull request May 30, 2024
feat: migrate NftController to BaseControllerV2 #4310
Merged
3 tasks

mcmire mentioned this pull request May 30, 2024
assets-controllers: Remove AllowedActions, AllowedEvents #4344
Merged
3 tasks

mcmire added 8 commits May 30, 2024 17:02

Update yarn.lock
4dd5504

Add changelog entries for PR 4310
c787fca

Update changelogs for PR 4319
cd3082d

Update references to versions in changelogs
73d9d77

Update changelogs for PR 4335
2064bba

Merge branch 'main' into release/158.0.0
c4ff489

Update lockfile
23ad398

Merge branch 'main' into release/158.0.0
aeb49f4

legobeat previously approved these changes May 31, 2024
View reviewed changes

MajorLift reviewed May 31, 2024
View reviewed changes

Comment threadpackages/assets-controllers/CHANGELOG.md Outdated

Remove mention of NftControllerMessenger
2d49b68
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>

mcmire dismissed legobeat’s stale review via 2d49b68May 31, 2024 15:19

montelaidevand others added 8 commits May 31, 2024 09:23

Add changelog entries for PR 4330
d28191e

Add changelog entries for PR 4343
2780b47

Merge branch 'main' into release/158.0.0
f96fead

Add changelog entry for PR 4235
2b9b0a4

Fix lint violation
4856c6c

dbrans previously approved these changes May 31, 2024
View reviewed changes

FrederikBolding previously approved these changes May 31, 2024
View reviewed changes

Mark PR 4235 as breaking
f45ee7f

mcmire dismissed stale reviews from FrederikBolding and dbrans via f45ee7fMay 31, 2024 15:57

FrederikBolding approved these changes May 31, 2024
View reviewed changes

cryptodev-2s approved these changes May 31, 2024
View reviewed changes

mcmire merged commit c2e6752 into mainMay 31, 2024

mcmire deleted the release/158.0.0 branch May 31, 2024 16:12

mcmire added a commit that referenced this pull request May 31, 2024
Revert "Release 158.0.0 (#4342)"
a2ea27f
This reverts commit c2e6752.

mcmire added a commit that referenced this pull request May 31, 2024
Revert "Release 158.0.0 (#4342)" (#4350)
3855767
This reverts commit c2e6752. We need to redo this release because the version set in `package.json` was wrong and therefore the release did not go out. 🤦🏻

Navigation Menu

Uh oh!

Uh oh!

Release 158.0.0 - #4342

Release 158.0.0#4342
mcmire merged 21 commits into
mainfrom
release/158.0.0

mcmire commented May 30, 2024•
edited
Loading

Uh oh!

mcmire commented May 30, 2024

Uh oh!

Uh oh!

mcmire commented May 30, 2024•
edited
Loading

Uh oh!

mcmire commented May 30, 2024

Uh oh!

legobeat commented May 30, 2024

Uh oh!

mcmire commented May 30, 2024

Uh oh!

legobeat left a comment

Uh oh!

dbrans commented May 31, 2024

Uh oh!

Uh oh!

mcmire commented May 31, 2024

Uh oh!

cryptodev-2s left a comment

Uh oh!

mcmire commented May 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

mcmire commented May 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Changelog

Checklist

Uh oh!

mcmire commented May 30, 2024

Uh oh!

Uh oh!

mcmire commented May 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcmire commented May 30, 2024

Uh oh!

legobeat commented May 30, 2024

Uh oh!

mcmire commented May 30, 2024

Uh oh!

legobeat left a comment

Choose a reason for hiding this comment

Uh oh!

dbrans commented May 31, 2024

Uh oh!

Uh oh!

mcmire commented May 31, 2024

Uh oh!

cryptodev-2s left a comment

Choose a reason for hiding this comment

Uh oh!

mcmire commented May 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mcmire commented May 30, 2024•
edited
Loading

mcmire commented May 30, 2024•
edited
Loading