Uh oh!
There was an error while loading. Please reload this page.
feat: add initial tracing to transaction controller - #4575
Merged
Conversation
matthewwalsh0
commented
Aug 2, 2024
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
commented
Aug 2, 2024
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
marked this pull request as ready for review
August 13, 2024 12:26
Uh oh!
There was an error while loading. Please reload this page.
pedronfigueiredo
approved these changes
Aug 15, 2024
matthewwalsh0
commented
Aug 16, 2024
MemberAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz pushed a commit
that referenced
this pull request
Sep 12, 2024
Add an optional `trace` constructor callback to the `TransactionController`. Add an optional `traceContext` argument to `addTransaction`. Add initial instrumentation of the transaction lifecycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add an optional
traceconstructor callback to theTransactionControllerto support generating Sentry traces within the controller, without coupling to the Sentry package.Add an optional
traceContextargument toaddTransactionto facilitate generating nested traces within a parent trace generated within a client.Add initial instrumentation of the transaction lifecycle.
References
#2849#2903
Changelog
@metamask/transaction-controllertracecallback to constructor.traceContextoption toaddTransactionmethod.Checklist