Skip to content

Release 202.0.0 - #4688

Closed
OGPoyraz wants to merge 10 commits into
mainfrom
release/202.0.0
Closed

Release 202.0.0#4688
OGPoyraz wants to merge 10 commits into
mainfrom
release/202.0.0

Conversation

@OGPoyraz

@OGPoyrazOGPoyraz commented Sep 11, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Explanation

This PR is release candidate for v202.0.0

Changelog

Changes

  • Bumped @metamask/controller-utils to ^11.3.0 for following packages

    • @metamask/address-book-controller
    • @metamask/assets-controller
    • @metamask/ens-controller
    • @metamask/gas-fee-controller
    • @metamask/logging-controller
    • @metamask/message-manager
    • @metamask/name-controller
    • @metamask/network-controller
    • @metamask/notification-services-controller
    • @metamask/permissions-controller
    • @metamask/polling-controller
    • @metamask/preferences-controller
    • @metamask/polling-controller
    • @metamask/queued-request-controller
    • @metamask/user-operation-controller
    • @metamask/transaction-controller
    • @metamask/signature-controller

  • Changes for @metamask/transaction-controller

    • Removed trace types from TransactionController, instead import them from @metamask/controller-utils (#4655)

  • Changes for @metamask/signature-controller

    • Add tracing infrastructure (#4575)
    • Add optional trace callback to constructor.
    • Add optional traceContext option to newUnsignedPersonalMessage and newUnsignedTypedMessage methods.
    • Add initial tracing of signature lifecycle.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz
OGPoyraz requested review from a team as code ownersSeptember 11, 2024 14:01
@OGPoyraz
OGPoyraz requested a review from a teamSeptember 11, 2024 14:01
MajorLift
MajorLift reviewed Sep 12, 2024
View reviewed changes

@MajorLiftMajorLift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added entries for controller-utils bumps.

It would also be nice to note the controller-utils bump in the PR description. It would be very helpful to future changelog writers releasing packages that updated their controller-utils versions in this pr but were not part of this release.

Comment threadpackages/signature-controller/CHANGELOG.md
Comment threadpackages/transaction-controller/CHANGELOG.md
@MajorLift

MajorLift commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

Looks like the lockfile needs an update. Otherwise LGTM!

@bergeronbergeron mentioned this pull request Sep 12, 2024
Merged
7 tasks
@OGPoyraz

OGPoyraz commented Sep 13, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks a lot for your input @MajorLift

MajorLift
MajorLift reviewed Sep 13, 2024
View reviewed changes
Comment threadpackages/signature-controller/CHANGELOG.md Outdated
MajorLift
MajorLift reviewed Sep 13, 2024
View reviewed changes
Comment threadpackages/transaction-controller/CHANGELOG.md
OGPoyrazand others added 2 commits September 13, 2024 09:25
@OGPoyraz@MajorLift
Update packages/signature-controller/CHANGELOG.md
38db9f5
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@OGPoyraz@MajorLift
Update packages/transaction-controller/CHANGELOG.md
afec6d7
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
MajorLift
MajorLift reviewed Sep 13, 2024
View reviewed changes
Comment threadpackages/transaction-controller/CHANGELOG.md
@OGPoyraz@MajorLift
Update packages/transaction-controller/CHANGELOG.md
3c1bbec
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
@MajorLift

MajorLift commented Sep 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

The controller-utils bump entry in the signature-controller changelog also needs to be restored. You might need to refresh the page to see the updates in this thread above.

matthewwalsh0
matthewwalsh0 requested changes Sep 13, 2024
View reviewed changes
Comment threadpackages/transaction-controller/CHANGELOG.md
MajorLift
MajorLift reviewed Sep 13, 2024
View reviewed changes
Comment threadpackages/controller-utils/CHANGELOG.md Outdated
matthewwalsh0
matthewwalsh0 requested changes Sep 14, 2024
View reviewed changes
Comment threadpackages/transaction-controller/CHANGELOG.md

### Changed

- Bump `@metamask/controller-utils` from `^11.2.0` to `^11.3.0` ([#4688](https://github.com/MetaMask/core/pull/4688))

@matthewwalsh0matthewwalsh0Sep 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the hassle, but we'll need to add the change log entries for the startup fixes also, thanks!

#4658

Mrtenz
Mrtenz requested changes Sep 16, 2024
View reviewed changes

@MrtenzMrtenz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do a release of all packages now that #4648 is merged. Happy to recreate this PR for you.

@OGPoyraz

OGPoyraz commented Sep 16, 2024

Copy link
Copy Markdown
MemberAuthor

We decided to close this and create new one with @Mrtenz

@Mrtenz
Mrtenz deleted the release/202.0.0 branch September 16, 2024 09:15
matthewwalsh0 added a commit that referenced this pull request Apr 24, 2025
@matthewwalsh0
feat: Add afterAdd hook to transaction controller (#5692)
9852a3c
## Explanation
Add optional `afterAdd` hook to mutate transactions added via
`addTransaction` method.
Persist original transaction params in new `txParamsOriginal` property.
## References
Fixes [#4688](MetaMask/MetaMask-planning#4688)
## Checklist
- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrtenzMrtenzMrtenz requested changes
@matthewwalsh0matthewwalsh0matthewwalsh0 requested changes
@MajorLiftMajorLiftMajorLift approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OGPoyraz@MajorLift@Mrtenz@matthewwalsh0