Skip to content

fix: change gas limit fallback - #4739

Merged
OGPoyraz merged 5 commits into
mainfrom
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
Oct 4, 2024
Merged

fix: change gas limit fallback#4739
OGPoyraz merged 5 commits into
mainfrom
19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations

Conversation

@OGPoyraz

@OGPoyrazOGPoyraz commented Sep 26, 2024

Copy link
Copy Markdown
Member

Explanation

This PR reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations.

References

Fixes: MetaMask/metamask-extension#19692

Changelog

@metamask/transaction-controller

  • CHANGED: Reduce gas limit fallback from 95% to 35% of the block gas limit on failed gas limit estimations

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@OGPoyraz
OGPoyraz requested a review from a team as a code ownerSeptember 26, 2024 10:52
@OGPoyrazOGPoyraz linked an issue Sep 26, 2024 that may be closed by this pull request
Reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations MetaMask/metamask-extension#19692
Closed
@OGPoyrazOGPoyraz changed the title change gas limit fallbackfix: change gas limit fallbackSep 26, 2024
matthewwalsh0
matthewwalsh0 requested changes Sep 26, 2024
View reviewed changes
Comment threadpackages/transaction-controller/src/utils/gas.ts
Comment threadpackages/transaction-controller/src/utils/gas.ts Outdated
) {
const estimatedGasBN = hexToBN(estimatedGas);
const maxGasBN = hexToBN(blockGasLimit).muln(0.9);
const maxGasBN = hexToBN(blockGasLimit).muln(0.3);

@matthewwalsh0matthewwalsh0Sep 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this also confirmed as a safe value?

@OGPoyrazOGPoyrazSep 30, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not an intended change, removed it.

@OGPoyraz
OGPoyrazforce-pushed the 19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations branch from 605eb03 to 1e6be12CompareSeptember 30, 2024 11:23
@OGPoyraz
Merge branch 'main' into 19692-reduce-gas-limit-fallback-from-95-to-3…
860256f
…5-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
vinistevam
vinistevam previously approved these changes Oct 4, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 previously approved these changes Oct 4, 2024
View reviewed changes
Comment threadpackages/transaction-controller/src/utils/gas.ts
Comment threadpackages/transaction-controller/src/utils/gas.ts Outdated
@OGPoyraz
OGPoyraz dismissed stale reviews from matthewwalsh0 and vinistevam via 9c94efbOctober 4, 2024 09:44
@OGPoyraz
Merge branch 'main' into 19692-reduce-gas-limit-fallback-from-95-to-3…
78e8004
…5-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@OGPoyraz
OGPoyraz merged commit f47ec00 into mainOct 4, 2024
@OGPoyraz
OGPoyraz deleted the 19692-reduce-gas-limit-fallback-from-95-to-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations branch October 4, 2024 10:06
This was referenced Oct 16, 2024
Merged
Merged
github-merge-queueBot pushed a commit to MetaMask/metamask-extension that referenced this pull request Oct 29, 2024
@OGPoyraz@matthewwalsh0
fix: Reduce gas limit fallback from 95% to 35% of the block gas limit…
f6b9e79
… on failed gas limit estimations (#27954)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
This PR applies the latest `transaction-controller` version that reduces
gas limit fallback.
[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27954?quickstart=1)
## **Related issues**
Fixes: MetaMask/core#4739
## **Manual testing steps**
NA
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [X] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [X] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
---------
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewwalsh0matthewwalsh0matthewwalsh0 approved these changes
+1 more reviewer
@vinistevamvinistevamvinistevam left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce gas limit fallback from 95% to 35% of the block gas limit to improve how we handle failed gas limit estimations

3 participants

@OGPoyraz@matthewwalsh0@vinistevam