Skip to content

Release 220.0.0 - #4798

Merged
legobeat merged 7 commits into
mainfrom
release/220.0.0
Oct 16, 2024
Merged

Release 220.0.0#4798
legobeat merged 7 commits into
mainfrom
release/220.0.0

Conversation

@legobeat

@legobeatlegobeat commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Explanation

References

Contents:

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@legobeat
legobeatforce-pushed the release/220.0.0 branch 2 times, most recently from 5909d39 to be2ac33CompareOctober 15, 2024 23:58
@legobeat
legobeat marked this pull request as ready for review October 16, 2024 00:00
@legobeat
legobeat requested review from a team as code ownersOctober 16, 2024 00:00
@legobeat
legobeat requested a review from a teamOctober 16, 2024 00:00
Comment threadpackages/json-rpc-engine/CHANGELOG.md Outdated
@legobeat

Copy link
Copy Markdown
ContributorAuthor

Looking at what comes next in terms of downstream updates, I think it would also be good to get @metamask/eth-json-rpc-provider in there:

@legobeat

This comment was marked as outdated.

@legobeat
legobeatforce-pushed the release/220.0.0 branch 2 times, most recently from b1e619e to bf3ff1cCompareOctober 16, 2024 09:17
@legobeat
legobeat marked this pull request as ready for review October 16, 2024 09:21
@legobeat
legobeat requested a review from a team as a code ownerOctober 16, 2024 09:21
@OGPoyraz

OGPoyraz commented Oct 16, 2024

Copy link
Copy Markdown
Member

This one is a bit urgent #4739, can we include transaction-controller in to this release?

@legobeat

legobeat commented Oct 16, 2024

Copy link
Copy Markdown
ContributorAuthor

This one is a bit urgent #4739, can we include transaction-controller in to this release?

I think it will make things a lot less messy if this can be released without including packages still transitively depending on old @metamask/json-rpc-engine versions in order to not introduce dependency inconsistencies within a package. After that, other packages should be releasable even without first merging the entirety of #4769, which depends on resolving those intermediaries.

If you think we can sort it out and that a single release is preferred, feel free to make a PR targeting this with the necessary changes, though.

@legobeat
legobeat merged commit c0e7783 into mainOct 16, 2024
@legobeat
legobeat deleted the release/220.0.0 branch October 16, 2024 21:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat@OGPoyraz@cryptodev-2s