Uh oh!
There was an error while loading. Please reload this page.
chore: downgrade snaps-controllers peer dependency from ^9.10.0 to ^9.7.0 - #4959
Merged
Merged
Conversation
snaps-controllers peer dependency from ^9.10.0 to ^9.7.0This change was not required, and bumping peer dependency does require the "consumer" of that packages to potentially update his packages too, which would result in a breaking change for the `accounts-controller` here.
ccharlyforce-pushed
the
chore/downgrade-snaps-controllers-peer-dep
branch
from
November 21, 2024 17:14
6e5b79d to
9f5788dCompare Merged
ccharly
marked this pull request as ready for review
November 21, 2024 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This change was not required, and bumping peer dependency does require the "consumer" of that packages to potentially update his packages too, which would result in a breaking change for the
accounts-controllerhere.References
Changelog
N/A (since we would revert to the state of the last release of the
accounts-controllerfor that specific line).Checklist