Uh oh!
There was an error while loading. Please reload this page.
feat: add MegaETH Testnet to network-controller - #5527
Merged
stanleyyconsensys merged 13 commits intoMar 27, 2025
Conversation
stanleyyconsensys
commented
Mar 24, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
stanleyyconsensys
commented
Mar 24, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
MegaETH Testnet to network controllerMegaETH Testnet to network controllerMegaETH Testnet to network-controllerstanleyyconsensys
commented
Mar 25, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
stanleyyconsensys
marked this pull request as ready for review
March 26, 2025 01:28
stanleyyconsensys
commented
Mar 26, 2025
ContributorAuthor
@metamaskbot publish-preview |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
stanleyyconsensysforce-pushed
the
feat/add-megaeth-testnet-to-network-controller
branch
from
March 26, 2025 02:50
57dc107 to
38ce0ecComparemcmire
reviewed
Mar 27, 2025
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Just one suggestion on this, otherwise this looks good.
Uh oh!
There was an error while loading. Please reload this page.
mcmire
reviewed
Mar 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
salimtb
approved these changes
Mar 27, 2025
OGPoyraz
approved these changes
Mar 27, 2025
stanleyyconsensys
enabled auto-merge (squash)
March 27, 2025 14:35
- fix mock network hardcoded mock path when RPC has endpoint with '/rpc' - fix test result on token detection when megaETH network added as default
stanleyyconsensysforce-pushed
the
feat/add-megaeth-testnet-to-network-controller
branch
from
March 27, 2025 14:36
39d35a4 to
80be045Comparewantedsystem
approved these changes
Mar 27, 2025
stanleyyconsensys
deleted the
feat/add-megaeth-testnet-to-network-controller
branch
March 27, 2025 14:41
4 tasks
7 tasks
github-merge-queueBot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Apr 8, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR is to add MegaETH as default network via NetworkController ( [5527](MetaMask/core#5527), [5495](MetaMask/core#5495) ) It also include a migration script to add/replace the MegaETH network for existing user ### **Change**: - Add MegaETH Testnet to default network via NetworkController options - `additionalDefaultNetworks` - Add migration script to replace/add MegaETH Testnet to the NetworkController state - Decouple the logic on method validateName from `NetworkSetting` to Network Utils `isValidNetworkName` for easier maintain and increase test coverage - Update Unit Test for MegaETH Testnet <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Setup a new wallet 2. Click on network menu and show test networks 3. You will see Sepolia , Linea Sepolia and Mega Testnet on test networks section 4. Click on Mega Testnet to switch the network 5. Send a transaction 6. Check the transaction result in the explorer ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="300" alt="Screenshot 2025-03-21 at 12 49 13" src="https://github.com/user-attachments/assets/69c95b03-0c95-4cae-bf2f-445a8893d0bf" /> <img width="300" alt="Screenshot 2025-03-21 at 12 49 38" src="https://github.com/user-attachments/assets/9e7e2274-b83a-4f72-898a-32a7b19e847f" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: wantedsystem <amine.harty@consensys.net> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> Co-authored-by: Mathieu Artu <mathieu.artu@consensys.net>
sethkfman pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Apr 9, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR is to add MegaETH as default network via NetworkController ( [5527](MetaMask/core#5527), [5495](MetaMask/core#5495) ) It also include a migration script to add/replace the MegaETH network for existing user ### **Change**: - Add MegaETH Testnet to default network via NetworkController options - `additionalDefaultNetworks` - Add migration script to replace/add MegaETH Testnet to the NetworkController state - Decouple the logic on method validateName from `NetworkSetting` to Network Utils `isValidNetworkName` for easier maintain and increase test coverage - Update Unit Test for MegaETH Testnet <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Setup a new wallet 2. Click on network menu and show test networks 3. You will see Sepolia , Linea Sepolia and Mega Testnet on test networks section 4. Click on Mega Testnet to switch the network 5. Send a transaction 6. Check the transaction result in the explorer ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="300" alt="Screenshot 2025-03-21 at 12 49 13" src="https://github.com/user-attachments/assets/69c95b03-0c95-4cae-bf2f-445a8893d0bf" /> <img width="300" alt="Screenshot 2025-03-21 at 12 49 38" src="https://github.com/user-attachments/assets/9e7e2274-b83a-4f72-898a-32a7b19e847f" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: wantedsystem <amine.harty@consensys.net> Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com> Co-authored-by: Mathieu Artu <mathieu.artu@consensys.net>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Further to Previous PR: #5495
We are adding MegaETH Testnet as default network on
Network Controllerdefault state -networkConfigurationsByChainIdwith the constants and type from the latestcontroller-utilsIn additional, a new constructor option
addtionalDefaultNetworkshas introduced inNetworkControllertoprevent client push the new network unintentionally
(such as bump up the network controller without support on the client side)
Changes:
Add Constructor Option
addtionalDefaultNetworksto specify the additional default networks to be included, which allows backward compatible and only include the Network if it has ready on client side (by developer specify)Refactor the logic to separate the construction of default network configurations to methods
getDefaultInfuraNetworkConfigurationsByChainIdandgetDefaultCustomNetworkConfigurationsByChainIdFix
mock-networknot support a use case when the RPC endpoint come with a path segment, e.g: 'https://carrot.megaeth.com/rpc'Add
MegaETH TestnetChainId into constantsCHAIN_IDSfromtransaction-controllerNote :
For everyone interested in testing this version in MM mobile you can use this branch to do so : https://github.com/MetaMask/metamask-mobile/tree/feat/add-megaeth-testnet
References
Changelog
@metamask/network-controlleraddtionalDefaultNetworksto specify the additional networks to be included as the default network.@metamask/transaction-controllerMegaETH TestnetChainId into constantsCHAIN_IDSChecklist