Uh oh!
There was an error while loading. Please reload this page.
NetworkController: Make failover URLs optional - #5561
Merged
Conversation
mcmireforce-pushed
the
make-rpc-failovers-optional
branch
from
March 27, 2025 14:56
f2378b3 to
9b7ee15Comparemcmire
marked this pull request as ready for review
March 27, 2025 16:51
mcmire
marked this pull request as draft
March 27, 2025 16:51
mcmire
commented
Mar 27, 2025
CollaboratorAuthor
@metamaskbot publish-previews |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This was referenced Mar 31, 2025
mcmire
commented
Apr 1, 2025
CollaboratorAuthor
@metamaskbot publish-previews |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mcmire
commented
Apr 1, 2025
CollaboratorAuthor
@metamaskbot publish-previews |
Contributor
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
There are two new non-optional properties that were added in a previous commit: - `failoverUrls` in `RpcEndpoint` (which is used in NetworkController state) - `failoverRpcUrls` in `NetworkClientConfiguration` (which is exposed via the network client) Making these properties non-optional makes sense to avoid `undefined`, however, this is requiring clients that wish to upgrade to implement a migration to ensure that state is valid along with many other changes to test files and such which expect state to be a certain shape. We would rather avoid this right now due to some other changes to `network-controller` that we need to adapt to, so to make the maintenance burden lighter, we are changing these to optional. We will change them back to non-optional in another commit.
mcmireforce-pushed
the
make-rpc-failovers-optional
branch
from
April 1, 2025 21:48
755989b to
924db9eComparemcmire
marked this pull request as ready for review
April 1, 2025 21:54
mcmire
commented
Apr 1, 2025
CollaboratorAuthor
Conflicts fixed, ready for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
There are two new non-optional properties that were added in a previous commit:
failoverUrlsinRpcEndpoint(which is used in NetworkController state)failoverRpcUrlsinNetworkClientConfiguration(which is exposed via the network client)Making these properties non-optional makes sense to avoid
undefined, however, this is requiring clients that wish to upgrade to implement a migration to ensure that state is valid along with many other changes to test files and such which expect state to be a certain shape. We would rather avoid this right now due to some other changes tonetwork-controllerthat we need to adapt to, so to make the maintenance burden lighter, we are changing these to optional. We will change them back to non-optional in another commit.References
This PR came out of a discussion with @stanleyyconsensys and others who are trying to get the changes in this PR integrated into Mobile: #5527
Changelog
(Updated in PR)
Checklist