Uh oh!
There was an error while loading. Please reload this page.
refactor: descriptive caip25CaveatBuilder unsupported scopes - #5806
Merged
adonesky1 merged 6 commits intoJun 12, 2025
Conversation
wenfix
marked this pull request as ready for review
May 14, 2025 17:49
jiexi
reviewed
May 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: jiexi <jiexiluan@gmail.com>
adonesky1
deleted the
refactor/caip25CaveatBuilder-unsupported-scope-exception
branch
June 12, 2025 16:43
Merged
adonesky1 added a commit
that referenced
this pull request
Jun 13, 2025
## @metamask/chain-agnostic-permission ## [0.7.1] ### Changed - Bump `@metamask/keyring-internal-api` to `^6.2.0` ([#5871](#5871)) - Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](#5935)) - Bump `@metamask/network-controller` to `^23.6.0` ([#5935](https://github.com/MetaMask/core/pull/5935),[#5882](https://github.com/MetaMask/core/pull/5882)) - Change `caip25CaveatBuilder` to list unsupported scopes in the unsupported scopes error ([#5806](#5806)) ### Fixed - Fix `isInternalAccountInPermittedAccountIds` and `isCaipAccountIdInPermittedAccountIds` to correctly handle comparison against `permittedAccounts` values of the `wallet:<namespace>:<address>` format ([#5980](#5980))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently the exception thrown by
caip25CaveatBuildervalidatordoesn't reference the unsupported scopes that caused it. With this change we list all the scopes that failed validation on the exception message when throwing it.References
Fixeshttps://github.com/MetaMask/MetaMask-planning/issues/4855
Changelog
Checklist