Skip to content

Release/430.0.0 - #5935

Merged
nickewansmith merged 2 commits into
mainfrom
release/430.0.0
Jun 6, 2025
Merged

Release/430.0.0#5935
nickewansmith merged 2 commits into
mainfrom
release/430.0.0

Conversation

@nickewansmith

Copy link
Copy Markdown
Contributor

Explanation

Release core v 430.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@nickewansmith
nickewansmith marked this pull request as ready for review June 6, 2025 14:00
@nickewansmith
nickewansmith requested review from a team as code ownersJune 6, 2025 14:00
@nickewansmith
nickewansmith requested a review from a teamJune 6, 2025 14:00
@nickewansmith
nickewansmith requested review from a team as code ownersJune 6, 2025 14:00
cryptodev-2s
cryptodev-2s previously requested changes Jun 6, 2025
Comment threadpackages/address-book-controller/package.json Outdated
Comment threadpackages/assets-controllers/CHANGELOG.md Outdated
Comment threadpackages/assets-controllers/package.json Outdated
Comment threadpackages/bridge-controller/package.json Outdated
Comment threadpackages/bridge-status-controller/package.json Outdated
Comment threadpackages/queued-request-controller/package.json Outdated
Comment threadpackages/remote-feature-flag-controller/package.json Outdated
Comment threadpackages/signature-controller/package.json Outdated
Comment threadpackages/transaction-controller/package.json Outdated
Comment threadpackages/user-operation-controller/package.json Outdated
@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@cryptodev-2s I don't understand why these other packages are receiving this version change that I don't expect. I would expect other packages to continue with the version they were using before. Will discuss with you in slack

Comment threadpackages/earn-controller/CHANGELOG.md Outdated
@nickewansmith
nickewansmithforce-pushed the release/430.0.0 branch 5 times, most recently from 15a636f to 1419a91CompareJune 6, 2025 20:11
Matt561
Matt561 previously approved these changes Jun 6, 2025

@mcmiremcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing but otherwise good to go!

Comment threadpackages/selected-network-controller/CHANGELOG.md Outdated
@nickewansmith
nickewansmithforce-pushed the release/430.0.0 branch 2 times, most recently from e6c5370 to aaefe12CompareJune 6, 2025 20:35
@nickewansmith
nickewansmith requested a review from mcmireJune 6, 2025 20:36
@mcmire
mcmire dismissed cryptodev-2s’s stale reviewJune 6, 2025 20:36

All requested changes seem to be addressed.

Comment on lines 10 to 14

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you can merge these:

Suggested change
### Changed
- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
### Changed
- Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722))
- Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812))
### Changed
- Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722))
- Bump `@metamask/controller-utils` to `^11.10.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812), [#5935](https://github.com/MetaMask/core/pull/5935))

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let me see if the lint passes as yarn changelog:validate is not catching the same errors ci seems to be. I'll make this change shortly

Comment on lines 13 to 14

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge these two ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge both controller utils under this Changed Section

Comment threadpackages/ens-controller/CHANGELOG.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge both controller utils under the Changed Section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge this with the below controller-utils bump while keeping one Changed Section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps in this section?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

Thank you two for the review, I just realized I was misusing the validation script and so I thought it was passing for me locally, but alas, it was not. I understand what I was doing wrong now!

@nickewansmith

Copy link
Copy Markdown
ContributorAuthor

@mcmire@cryptodev-2s I think it should be gtg this time 🤞🏽

@cryptodev-2scryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickewansmith
nickewansmith merged commit 3cd5946 into mainJun 6, 2025
@nickewansmith
nickewansmith deleted the release/430.0.0 branch June 6, 2025 21:16
@mcmiremcmire mentioned this pull request Jun 13, 2025
4 tasks
@adonesky1adonesky1 mentioned this pull request Jun 13, 2025
adonesky1 added a commit that referenced this pull request Jun 13, 2025
## @metamask/chain-agnostic-permission
## [0.7.1]
### Changed
- Bump `@metamask/keyring-internal-api` to `^6.2.0`
([#5871](#5871))
- Bump `@metamask/controller-utils` to `^11.10.0`
([#5935](#5935))
- Bump `@metamask/network-controller` to `^23.6.0`
([#5935](https://github.com/MetaMask/core/pull/5935),[#5882](https://github.com/MetaMask/core/pull/5882))
- Change `caip25CaveatBuilder` to list unsupported scopes in the
unsupported scopes error
([#5806](#5806))
### Fixed
- Fix `isInternalAccountInPermittedAccountIds` and
`isCaipAccountIdInPermittedAccountIds` to correctly handle comparison
against `permittedAccounts` values of the `wallet:<namespace>:<address>`
format ([#5980](#5980))
@adonesky1adonesky1 mentioned this pull request Jun 20, 2025
adonesky1 added a commit that referenced this pull request Jun 20, 2025
## @metamask/chain-agnostic-permission
## [1.0.0]
### Changed
- This package is now considered stable
## @metamask/eip1193-permission-middleware
## [1.0.0]
### Changed
- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5518](#5518),
[#5674](#5674),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5550](#5550),
[#5518](#5518),
[#5674](#5674),
[#5715](#5715),
[#5760](#5760),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/controller-utils` to `^11.10.0`
([#5935](#5935),
[#5583](#5583),
[#5765](#5765),
[#5812](#5812))
## @metamask/multichain-api-middleware
## [1.0.0]
### Changed
- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5518](#5518),
[#5674](#5674),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5550](#5550),
[#5518](#5518),
[#5674](#5674),
[#5715](#5715),
[#5760](#5760),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/controller-utils` to `^11.10.0`
([#5935](#5935),
[#5583](#5583),
[#5765](#5765),
[#5812](#5812))
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickewansmith@mcmire@Matt561@cryptodev-2s