refactor: migrate {Approval,Transaction,Network,GasFee,AssetsContract,Nft,Tokens}Controller messengers

[mikesposito]

Explanation

This PR migrates the ApprovalController, TransactionController, GasFeeController, NetworkController, AssetsContractController, TokensController and NftController classes to the new @metamask/messenger comm system along with their tests, as opposed to the one exported from @metamask/base-controller.

The three packages are being migrated together because the TransactionControllerIntegration.test.ts file ties them together.

References

• Related to Implement messenger delegation #5626

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Migrates major controllers to the new @metamask/messenger with updated state metadata and tests, adds StaticIntervalPollingControllerNext, and updates package configs and changelogs (breaking).

• Messaging/Controllers (BREAKING):
  • Migrate ApprovalController, TransactionController, NetworkController, GasFeeController, AssetsContractController, NftController, TokensController from RestrictedMessenger to new @metamask/messenger.
  • Replace @metamask/base-controller APIs with @metamask/base-controller/next where applicable; update state metadata keys (anonymous -> includeInDebugSnapshot).
  • Update controller messenger types, action/event registrations (this.messenger.registerActionHandler/subscribe/publish/call).
  • Refactor tests to use root and namespaced messengers with delegated actions/events.
• Gas Fee/Pooling:
  • Add StaticIntervalPollingControllerNext; GasFeeController now extends it.
  • Export GasFeeMessenger type.
• Configs/Deps:
  • Add @metamask/messenger dependency and TS project references across affected packages; adjust imports to /next variants.
  • Update README controller dependency graph to include messenger links.
• Changelogs:
  • Note BREAKING changes for the controllers above; document new export in gas-fee-controller.
• Misc:
  • Minor eslint threshold tweak; yarn.lock updates.

^{Written by Cursor Bugbot for commit c2dee6e. This will update automatically on new commits. Configure here.}

[mcmire]

It looks like these changes cause some issues with the gas-fee-controller tests :(

[mikesposito]

It looks like these changes cause some issues with the gas-fee-controller tests :(

Ah, thanks for pointing that out! It looks like gas-fee-controller tests also initialize other controller instances in its tests, so it should be migrated as well in this PR. Unfortunately though, gas-fee-controller also depends on StaticIntervalPollingController from polling-controller, and migrating that will require migrating all other controllers doing polling

EDIT: I was able to go around this by adding a StaticIntervalPollingControllerNext export in polling-controller, so that I can migrate gas-fee-controller without having to migrate all other polling controllers. There are still other controllers depending on the ones being migrated in this PR though (i.e. mainly assets controllers)

[mikesposito]

This has been added to untangle gas-fee-controller from other polling controllers, and is being removed in #6444

[mcmire]

Looks like there are conflicts :(

[cryptodev-2s]

LGTM!