Uh oh!
There was an error while loading. Please reload this page.
refactor: migrate polling controllers to @metamask/messenger - #6444
Merged
Conversation
4 tasks
mikespositoforce-pushed
the
mikesposito/messenger/polling-controllers
branch
3 times, most recently
from
September 3, 2025 20:31
d7a952f to
f882350Comparemikespositoforce-pushed
the
mikesposito/messenger/approval-controller
branch
from
September 3, 2025 20:39
bf8b850 to
31c7ee0Compare…sito/messenger/polling-controllers
…sito/messenger/polling-controllers
…sito/messenger/polling-controllers
…ontroller' into mikesposito/messenger/polling-controllers * origin/mikesposito/messenger/approval-controller: Update changelogs following branch update Update messagingSystem references to messenger
Gudahttforce-pushed
the
mikesposito/messenger/polling-controllers
branch
from
October 24, 2025 18:53
0f39c68 to
221243eCompare
Base automatically changed from
mikesposito/messenger/approval-controller to
mainOctober 27, 2025 11:25
FrederikBolding
dismissed
cryptodev-2s’s stale reviewOctober 27, 2025 11:25
The base branch was changed.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cryptodev-2s
previously approved these changes
Oct 27, 2025
cryptodev-2s
approved these changes
Oct 27, 2025
mikesposito
enabled auto-merge
October 27, 2025 12:12
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates all controllers extending
StaticIntervalPollingControllerto use@metamask/messengerinstead of@metamask/base-controller. This is part of a larger effort to migrate all controllers to use@metamask/messenger.References
Checklist
Note
Migrates polling infrastructure and multiple controllers to use @metamask/messenger, updates state metadata APIs/tests, and adjusts dependencies and exports across affected packages.
RestrictedMessengerwith@metamask/messengeracross controllers:AccountTrackerController,CurrencyRateController,DeFiPositionsController,MultichainAssetsRatesController,TokenBalancesController,TokenDetectionController,TokenListController,TokenRatesController,BridgeController,BridgeStatusController, andSubscriptionController.Messengerinstances; switchderiveStateFromMetadataimports to@metamask/base-controller/next.StaticIntervalPollingControllerandBlockTrackerPollingControllerto use@metamask/messenger; removeStaticIntervalPollingControllerNext.GasFeeControllerto extendStaticIntervalPollingController.anonymoustoincludeInDebugSnapshotand adjust usage in controllers/tests.BridgeControllerGetStateActionandBridgeControllerStateChangeEventtypes; integrate messenger for actions/subscriptions; fetch/track calls updated.@metamask/messengerdependencies; update TS references; minor README dependency graph tweaks.Written by Cursor Bugbot for commit b9a05a4. This will update automatically on new commits. Configure here.