Skip to content

BREAKING: increase minimum node version to 10.19 - #16

Merged
legobeat merged 10 commits into
MetaMask:mainfrom
legobeat:node-10
Oct 21, 2024
Merged

BREAKING: increase minimum node version to 10.19#16
legobeat merged 10 commits into
MetaMask:mainfrom
legobeat:node-10

Conversation

@legobeat

@legobeatlegobeat commented Oct 21, 2024

Copy link
Copy Markdown

Changes

  • BREAKING: increase minimum node version to 10.19
    • Remove support for major node.js versions 8-9, 11, 13, 15, 17, 19
  • Increase minimum NPM version to v7
    • Lockfile format v2
  • devDeps: eslint@^5.4.0->^7.32.0
  • devDeps: bump eslint plugins
  • devDeps: chai@^4.3.10->^4.5.0
  • devDeps: mocha@^7.2.0->^8.4.0
  • devDeps: cross-env@^6.0.3->^7.0.3

The devDependency bumps are the ones unblocked by dropping nodejs v8 support. webpack is also in that category but keeping that out of this PR as it's a bit more involved to upgrade.

Related

@socket-security

socket-securityBot commented Oct 21, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/chai@4.5.0None+7910 kBchaijs
npm/cross-env@7.0.3environment Transitive: filesystem, shell+681.2 kBkentcdodds
npm/eslint-config-airbnb@18.2.1Transitive: environment, eval+694.06 MBljharb
npm/eslint-import-resolver-webpack@0.13.9filesystem Transitive: environment, eval+262.08 MBljharb
npm/eslint-plugin-import@2.31.0Transitive: environment, eval, filesystem, unsafe+936.11 MBbenmosher, jfmengels, ljharb
npm/eslint@7.32.0filesystem Transitive: environment, eval, shell, unsafe+10012.1 MBeslintbot
npm/lint-staged@12.5.0Transitive: environment, filesystem, shell+676.84 MBokonet
npm/mocha@8.4.0environment, eval, filesystem Transitive: shell+716.08 MBjuergba

🚮 Removed packages:npm/@babel/code-frame@7.22.13, npm/@babel/helper-validator-identifier@7.22.20, npm/@babel/highlight@7.22.20, npm/acorn@6.4.2, npm/ansi-colors@3.2.3, npm/ansi-escapes@3.2.0, npm/ansi-styles@2.2.1, npm/argparse@0.1.16, npm/array-buffer-byte-length@1.0.0, npm/array-find@1.0.0, npm/array-includes@3.1.7, npm/array.prototype.findlastindex@1.2.3, npm/array.prototype.reduce@1.0.6, npm/arraybuffer.prototype.slice@1.0.2, npm/astral-regex@1.0.0, npm/available-typed-arrays@1.0.5, npm/binary-extensions@1.11.0, npm/braces@3.0.2, npm/call-bind@1.0.5, npm/chai@4.3.10, npm/chalk@1.1.3, npm/chardet@0.7.0, npm/chokidar@3.5.3, npm/cli-cursor@1.0.2, npm/cli-spinners@0.1.2, npm/cli-width@2.2.1, npm/commander@2.15.1, npm/cross-env@6.0.3, npm/define-data-property@1.1.1, npm/diff@3.5.0, npm/emoji-regex@7.0.3, npm/es-abstract@1.22.3, npm/es-array-method-boxes-properly@1.0.0, npm/es-set-tostringtag@2.0.2, npm/eslint-config-airbnb-base@13.2.0, npm/eslint-config-airbnb@17.1.1, npm/eslint-import-resolver-webpack@0.2.4, npm/eslint-module-utils@2.8.0, npm/eslint-plugin-import@2.29.0, npm/eslint-scope@4.0.3, npm/eslint-utils@1.4.3, npm/eslint@5.16.0, npm/espree@5.0.1, npm/esrecurse@4.2.1, npm/estraverse@4.2.0, npm/exit-hook@1.1.1, npm/external-editor@3.1.0, npm/figures@2.0.0, npm/file-entry-cache@5.0.1, npm/fill-range@7.0.1, npm/find-root@0.1.2, npm/flat-cache@2.0.1, npm/flat@4.1.1, npm/flatted@2.0.2, npm/get-intrinsic@1.2.2, npm/get-symbol-description@1.0.0, npm/has-ansi@2.0.0, npm/has-property-descriptors@1.0.1, npm/has-proto@1.0.1, npm/has-tostringtag@1.0.0, npm/hasown@2.0.0, npm/iconv-lite@0.4.24, npm/inquirer@6.5.2, npm/internal-slot@1.0.6, npm/interpret@1.1.0, npm/is-absolute@0.2.6, npm/is-array-buffer@3.0.2, npm/is-core-module@2.13.1, npm/is-negative-zero@2.0.2, npm/is-relative@0.2.1, npm/is-shared-array-buffer@1.0.2, npm/is-typed-array@1.1.12, npm/is-unc-path@0.1.2, npm/is-windows@0.2.0, npm/js-tokens@3.0.2, npm/js-yaml@3.0.1, npm/lint-staged@1.0.1, npm/lodash._baseget@3.7.2, npm/lodash._topath@3.8.1, npm/lodash.get@3.7.0, npm/lodash.isarray@3.0.4, npm/log-symbols@3.0.0, npm/minimist@0.0.8, npm/mocha@7.2.0, npm/mute-stream@0.0.7, npm/nice-try@1.0.5, npm/node-environment-flags@1.0.6, npm/npm-path@1.1.0, npm/npm-which@2.0.0, npm/object.assign@4.1.0, npm/object.fromentries@2.0.7, npm/object.getownpropertydescriptors@2.1.7, npm/object.groupby@1.0.1, npm/object.values@1.1.7, npm/onetime@1.1.0, npm/optionator@0.8.2, npm/ora@0.2.3, npm/os-tmpdir@1.0.2, npm/path-is-inside@1.0.2, npm/readable-stream@2.3.6, npm/readdirp@3.6.0, npm/regexp.prototype.flags@1.5.1, npm/regexpp@2.0.1, npm/resolve@1.7.0, npm/restore-cursor@1.0.1, npm/run-async@2.4.1, npm/rxjs@6.6.7, npm/safe-array-concat@1.0.1, npm/safe-buffer@5.1.1, npm/safe-regex-test@1.0.0, npm/set-function-length@1.1.1, npm/set-function-name@2.0.1, npm/slice-ansi@2.1.0, npm/staged-git-files@0.0.4, npm/string.prototype.trim@1.2.8, npm/string.prototype.trimend@1.0.7, npm/string.prototype.trimstart@1.0.7, npm/strip-json-comments@2.0.1, npm/supports-color@2.0.0, npm/table@5.4.6, npm/tmp@0.0.33, npm/tsconfig-paths@3.14.2, npm/tslib@1.14.1, npm/type-detect@4.0.8, npm/typed-array-buffer@1.0.0, npm/typed-array-byte-length@1.0.0, npm/typed-array-byte-offset@1.0.0, npm/typed-array-length@1.0.4, npm/unc-path-regex@0.1.2, npm/underscore.string@2.4.0, npm/underscore@1.7.0, npm/which-typed-array@1.1.13, npm/which@1.3.0, npm/write@1.0.3, npm/y18n@4.0.3, npm/yargs-unparser@1.6.0

View full report↗︎

@socket-security

socket-securityBot commented Oct 21, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/v8-compile-cache@2.4.0, npm/estraverse@4.3.0, npm/merge-stream@2.0.0, npm/@humanwhocodes/object-schema@1.2.1, npm/@humanwhocodes/config-array@0.5.0, npm/find-root@1.1.0, npm/nanoid@3.1.20

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @legobeatlegobeat changed the title node 10BREAKING: increase minimum node version to 10.19Oct 21, 2024
    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/v8-compile-cache@2.4.0
    @SocketSecurity ignore npm/estraverse@4.3.0
    @SocketSecurity ignore npm/find-root@1.1.0
    

    new authors ok

    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/nanoid@3.1.20
    

    CVE N/A

    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/@humanwhocodes/object-schema@1.2.1
    @SocketSecurity ignore npm/@humanwhocodes/config-array@0.5.0
    

    deprecated would be addressed by further upgrading eslint and breaking Node 10

    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/merge-stream@2.0.0
    

    new author ok

    @legobeat
    legobeat marked this pull request as ready for review October 21, 2024 21:50
    @legobeat
    legobeat requested review from a team and NEllusionOctober 21, 2024 21:50
    shell: bash
    run: |
    if ! git diff --exit-code -- . ':!dist/*.map' ':!package-lock.json'; then
    if ! git diff -b --exit-code -- . ':!dist/*.map' ':!package-lock.json'; then

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice enhancement

    @legobeat
    legobeat merged commit b1aff05 into MetaMask:mainOct 21, 2024
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @legobeat@NEllusion