Skip to content

BREAKING: increase minimum node version to v10 - #20

Merged
legobeat merged 7 commits into
MetaMask:mainfrom
legobeat:node-10
Feb 22, 2024
Merged

BREAKING: increase minimum node version to v10#20
legobeat merged 7 commits into
MetaMask:mainfrom
legobeat:node-10

Conversation

@legobeat

@legobeatlegobeat commented Feb 19, 2024

Copy link
Copy Markdown

Changes

  • BREAKING: increase minimum node version to 10.19
    • Remove support for major node.js versions 8-9, 11, 13, 15, 17, 19
  • devDeps: eslint@^5.4.0->^7.32.0
  • devDeps: bump eslint plugins
  • devDeps: chai@^4.3.10->^4.4.1
  • devDeps: mocha@^7.2.0->^8.4.0
  • devDeps: cross-env@^6.0.3->^7.0.3

The devDependency bumps are the ones unblocked by dropping nodejs v8 support. webpack is also in that category but keeping that out of this PR as it's a bit more involved to upgrade.

(happy to split this up if desired by any reviewer)

Related

Blocking

@socket-security

socket-securityBot commented Feb 19, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@aashutoshrathi/word-wrap@1.2.6None010.9 kBaashutoshrathi
npm/@babel/runtime@7.23.9None+1277 kBnicolo-ribaudo
npm/@eslint/eslintrc@0.4.3filesystem, unsafe Transitive: environment, eval+266.01 MBeslintbot
npm/@humanwhocodes/config-array@0.5.0None+5142 kBnzakas
npm/@humanwhocodes/object-schema@1.2.1None049.4 kBnzakas
npm/@ungap/promise-all-settled@1.1.2None04.88 kBwebreflection
npm/ansi-colors@4.1.1environment024.4 kBjonschlinkert
npm/array.prototype.filter@1.0.3Transitive: eval+574.3 MBljharb
npm/array.prototype.find@2.2.2Transitive: eval+574.3 MBljharb
npm/array.prototype.findlastindex@1.2.4Transitive: eval+584.33 MBljharb
npm/array.prototype.tosorted@1.1.3Transitive: eval+584.32 MBljharb
npm/ast-types-flow@0.0.8None0126 kBkyldvs
npm/astral-regex@2.0.0None03.4 kBkevva
npm/axe-core@4.7.0None02.18 MBnpmdeque
npm/chai@4.4.1None+7923 kBkeithamus
npm/cross-env@7.0.3environment Transitive: filesystem, shell+681.2 kBkentcdodds
npm/diff@5.0.0None0369 kBkpdecker
npm/emoji-regex@8.0.0None048.3 kBmathias
npm/enquirer@2.4.1environment+3223 kBjonschlinkert
npm/es-define-property@1.0.0Transitive: eval+6136 kBljharb
npm/es-errors@1.3.0None012.3 kBljharb
npm/es-iterator-helpers@1.0.17Transitive: eval+927.1 MBljharb
npm/eslint-config-airbnb-base@14.2.1Transitive: environment, eval, filesystem, unsafe+19019.4 MBljharb
npm/eslint-config-airbnb@18.2.1Transitive: environment, eval, filesystem, unsafe+25129.2 MBljharb
npm/eslint-import-resolver-webpack@0.13.8filesystem Transitive: environment, eval, network, shell, unsafe+49133.3 MBljharb
npm/eslint-plugin-import@2.29.1filesystem, unsafe Transitive: environment, eval+18719.3 MBljharb
npm/eslint-plugin-jsx-a11y@6.8.0Transitive: environment, eval, filesystem, unsafe+21925.7 MBljharb
npm/eslint-plugin-react-hooks@4.6.0environment Transitive: eval, filesystem, unsafe+10713 MBgnoff
npm/eslint-utils@2.1.0None+1366 kBmysticatea
npm/eslint@7.32.0filesystem Transitive: environment, eval, unsafe+10612.9 MBeslintbot
npm/espree@7.3.1None+33.33 MBeslintbot
npm/file-entry-cache@6.0.1filesystem Transitive: environment+16290 kBroyriojas
npm/find-root@1.1.0filesystem05.27 kBjsdnxx
npm/flat-cache@3.2.0filesystem Transitive: environment+15264 kBjaredwray
npm/flat@5.0.2None026.6 kBtimoxley
npm/flatted@3.2.9None040.1 kBwebreflection
npm/is-plain-obj@2.1.0None03.69 kBsindresorhus
npm/json-buffer@3.0.1None05.4 kBdominictarr
npm/keyv@4.5.4None+133.2 kBjaredwray
npm/language-tags@1.0.9None+11.57 MBmcg
npm/lodash.merge@4.6.2None054.1 kBjdalton
npm/lodash.truncate@4.4.2None019.8 kBjdalton
npm/log-symbols@4.0.0environment04.58 kBsindresorhus
npm/mocha@8.4.0environment, eval, filesystem Transitive: shell+685.9 MBjuergba
npm/nanoid@3.1.20None057.5 kBai
npm/object.groupby@1.0.2Transitive: eval+594.33 MBljharb
npm/reflect.getprototypeof@1.0.5Transitive: eval+674.46 MBljharb
npm/regenerator-runtime@0.14.1None027.9 kBbenjamn
npm/regexpp@3.2.0None0302 kBmysticatea
npm/require-from-string@2.0.2unsafe03.42 kBfloatdrop
npm/serialize-javascript@5.0.1None+254.6 kBokuryu
npm/slice-ansi@4.0.0None+565.7 kBsindresorhus
npm/strip-json-comments@3.1.1None06.96 kBsindresorhus
npm/supports-color@8.1.1None+112.9 kBsindresorhus
npm/table@6.8.1None+10474 kBgajus-table
npm/tsconfig-paths@3.15.0environment, filesystem, unsafe+3300 kBjonaskello
npm/type-fest@0.20.2None0111 kBsindresorhus
npm/v8-compile-cache@2.4.0environment, filesystem, unsafe014.9 kByungsters
npm/workerpool@6.1.0None0323 kBjosdejong
npm/yargs-unparser@2.0.0None+459.8 kBoss-bot
npm/yocto-queue@0.1.0None06.03 kBsindresorhus

🚮 Removed packages:npm/@babel/runtime@7.23.2, npm/ansi-colors@3.2.3, npm/ansi-escapes@3.2.0, npm/array-find@1.0.0, npm/array.prototype.findlastindex@1.2.3, npm/array.prototype.reduce@1.0.6, npm/array.prototype.tosorted@1.1.2, npm/ast-types-flow@0.0.7, npm/astral-regex@1.0.0, npm/axe-core@4.8.2, npm/chai@4.3.10, npm/chardet@0.7.0, npm/cli-cursor@2.1.0, npm/cli-width@2.2.1, npm/cross-env@6.0.3, npm/diff@3.5.0, npm/emoji-regex@7.0.3, npm/es-iterator-helpers@1.0.15, npm/eslint-config-airbnb-base@13.2.0, npm/eslint-config-airbnb@17.1.1, npm/eslint-import-resolver-webpack@0.2.4, npm/eslint-plugin-import@2.29.0, npm/eslint-plugin-jsx-a11y@6.7.1, npm/eslint-utils@1.4.3, npm/eslint@5.16.0, npm/espree@5.0.1, npm/external-editor@3.1.0, npm/figures@2.0.0, npm/file-entry-cache@5.0.1, npm/find-root@0.1.2, npm/flat-cache@2.0.1, npm/flat@4.1.1, npm/flatted@2.0.2, npm/has@1.0.4, npm/iconv-lite@0.4.24, npm/inquirer@6.5.2, npm/is-absolute@0.2.6, npm/is-relative@0.2.1, npm/is-unc-path@0.1.2, npm/is-windows@0.2.0, npm/language-tags@1.0.5, npm/lodash._baseget@3.7.2, npm/lodash._topath@3.8.1, npm/lodash.get@3.7.0, npm/lodash.isarray@3.0.4, npm/log-symbols@3.0.0, npm/mocha@7.2.0, npm/mute-stream@0.0.7, npm/nice-try@1.0.5, npm/node-environment-flags@1.0.6, npm/object.getownpropertydescriptors@2.1.7, npm/object.groupby@1.0.1, npm/onetime@2.0.1, npm/os-tmpdir@1.0.2, npm/path-is-inside@1.0.2, npm/reflect.getprototypeof@1.0.4, npm/regenerator-runtime@0.14.0, npm/regexpp@2.0.1, npm/resolve@1.7.1, npm/restore-cursor@2.0.0, npm/run-async@2.4.1, npm/rxjs@6.6.7, npm/slice-ansi@2.1.0, npm/strip-json-comments@2.0.1, npm/supports-color@6.0.0, npm/table@5.4.6, npm/through@2.3.8, npm/tmp@0.0.33, npm/tsconfig-paths@3.14.2, npm/tslib@1.14.1, npm/unc-path-regex@0.1.2, npm/write@1.0.3, npm/yargs-unparser@1.6.0

View full report↗︎

@socket-security

socket-securityBot commented Feb 19, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/eslint-plugin-react-hooks@4.6.0, npm/find-root@1.1.0, npm/nanoid@3.1.20, npm/v8-compile-cache@2.4.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @legobeatlegobeat mentioned this pull request Feb 19, 2024
    1 task
    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/v8-compile-cache@2.4.0
    @SocketSecurity ignore npm/eslint-plugin-react-hooks@4.6.0
    @SocketSecurity ignore npm/find-root@1.1.0
    

    new author ok

    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/nanoid@3.1.20
    

    known mocha legacy

    @legobeat
    legobeat marked this pull request as ready for review February 19, 2024 06:51
    @legobeatlegobeat mentioned this pull request Feb 19, 2024
    2 tasks

    @NEllusionNEllusion left a comment

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @legobeat@NEllusion