Skip to content

Disable babelification - #21

Merged
legobeat merged 6 commits into
MetaMask:mainfrom
legobeat:no-babelification
Oct 22, 2024
Merged

Disable babelification#21
legobeat merged 6 commits into
MetaMask:mainfrom
legobeat:no-babelification

Conversation

@legobeat

@legobeatlegobeat commented Feb 19, 2024

Copy link
Copy Markdown

Changes

  • BREAKING: Remove all use of babel transforms
    • This now assumes runtime support of targeted es6 (aka es2015).
    • https://caniuse.com/es6
    • Still supported on:
      • Node.js 10
      • Safari iOS 10 (iPhone 5)
      • Firefox 54
      • Chrome 51
      • Edge 79
      • Opera 38
  • Remove peerDependency @babel/runtime
  • webpack: remove use of babel-loader

babel-cli is still used by package scripts as part of the build process of commonjs output (./lib).

Related

Blocking

Blocked by

@socket-security

socket-securityBot commented Feb 19, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/aproba@1.2.0None08.18 kBiarna
npm/bluebird@3.7.2environment, eval, unsafe0632 kBesailija
npm/cacache@10.0.4environment, filesystem+1113 kBzkat
npm/chownr@1.1.4filesystem05.71 kBisaacs
npm/copy-concurrently@1.0.5filesystem021.5 kBiarna
npm/cyclist@1.0.2None04.45 kBmafintosh
npm/duplexify@3.7.1None017.1 kBmafintosh
npm/end-of-stream@1.4.4None06.23 kBmafintosh
npm/find-cache-dir@1.0.0Transitive: filesystem+219.1 kBsindresorhus
npm/flush-write-stream@1.1.1None06.5 kBmafintosh
npm/from2@2.3.0None09.35 kBmafintosh
npm/fs-write-stream-atomic@1.0.10None018.7 kBiarna
npm/iferr@0.1.5None05.43 kBnadav
npm/mississippi@2.0.0None016.1 kBbret
npm/move-concurrently@1.0.1filesystem+123.4 kBiarna
npm/parallel-transform@1.2.0None05.54 kBmafintosh
npm/pkg-dir@2.0.0None03.5 kBsindresorhus
npm/promise-inflight@1.0.1None03.04 kBiarna
npm/pump@2.0.1filesystem07.38 kBmafintosh
npm/pumpify@1.5.1None010.2 kBmafintosh
npm/run-queue@1.0.3None05.76 kBiarna
npm/schema-utils@0.4.7filesystem010.7 kBmichael-ciniawsky
npm/ssri@5.3.0None040.5 kBzkat
npm/stream-each@1.2.3None06.74 kBmafintosh
npm/stream-shift@1.0.3None04.46 kBmafintosh
npm/through2@2.0.5None09.65 kBrvagg
npm/uglify-es@3.3.9eval, filesystem Transitive: shell+1824 kBalexlamsl
npm/uglifyjs-webpack-plugin@1.3.0eval+174.5 kBevilebottnawi
npm/unique-filename@1.1.1None041.4 kBiarna
npm/unique-slug@2.0.2None02.68 kBzkat
npm/worker-farm@1.7.0environment, shell049.9 kBrvagg

🚮 Removed packages:npm/@babel/helper-annotate-as-pure@7.22.5, npm/@babel/helper-create-regexp-features-plugin@7.22.15, npm/@babel/helper-member-expression-to-functions@7.23.0, npm/@babel/helper-optimise-call-expression@7.22.5, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/helper-replace-supers@7.22.20, npm/@babel/helper-skip-transparent-expression-wrappers@7.22.5, npm/@babel/plugin-syntax-object-rest-spread@7.8.3, npm/@babel/plugin-transform-arrow-functions@7.22.5, npm/@babel/plugin-transform-block-scoped-functions@7.22.5, npm/@babel/plugin-transform-block-scoping@7.23.0, npm/@babel/plugin-transform-classes@7.22.15, npm/@babel/plugin-transform-computed-properties@7.22.5, npm/@babel/plugin-transform-destructuring@7.23.0, npm/@babel/plugin-transform-for-of@7.22.15, npm/@babel/plugin-transform-function-name@7.22.5, npm/@babel/plugin-transform-literals@7.22.5, npm/@babel/plugin-transform-member-expression-literals@7.22.5, npm/@babel/plugin-transform-modules-commonjs@7.23.0, npm/@babel/plugin-transform-object-rest-spread@7.22.15, npm/@babel/plugin-transform-object-super@7.22.5, npm/@babel/plugin-transform-parameters@7.22.15, npm/@babel/plugin-transform-property-literals@7.22.5, npm/@babel/plugin-transform-shorthand-properties@7.22.5, npm/@babel/plugin-transform-spread@7.22.5, npm/@babel/plugin-transform-sticky-regex@7.22.5, npm/@babel/plugin-transform-template-literals@7.22.5, npm/@babel/plugin-transform-unicode-regex@7.22.5, npm/@babel/register@7.22.15, npm/@babel/regjsgen@0.8.0, npm/@types/json-schema@7.0.14, npm/babel-loader@8.3.0, npm/bindings@1.5.0, npm/clone-deep@4.0.1, npm/file-uri-to-path@1.0.0, npm/find-cache-dir@2.1.0, npm/find-up@3.0.0, npm/loader-utils@2.0.4, npm/nan@2.18.0, npm/pirates@4.0.6, npm/pkg-dir@3.0.0, npm/regenerate-unicode-properties@10.1.1, npm/regenerate@1.4.2, npm/regexpu-core@5.3.2, npm/regjsparser@0.9.1, npm/schema-utils@2.7.1, npm/shallow-clone@3.0.1, npm/source-map-support@0.5.21, npm/unicode-canonical-property-names-ecmascript@2.0.0, npm/unicode-match-property-ecmascript@2.0.0, npm/unicode-match-property-value-ecmascript@2.1.0, npm/unicode-property-aliases-ecmascript@2.1.0

View full report↗︎

@socket-security

socket-securityBot commented Feb 19, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/uglify-es@3.3.9, npm/unique-slug@2.0.2, npm/serialize-javascript@1.9.1, npm/copy-concurrently@1.0.5, npm/fs-write-stream-atomic@1.0.10, npm/move-concurrently@1.0.1, npm/worker-farm@1.7.0, npm/find-cache-dir@1.0.0, npm/ssri@5.3.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @legobeatlegobeat mentioned this pull request Feb 19, 2024
    2 tasks
    @legobeat
    legobeatforce-pushed the no-babelification branch 3 times, most recently from 1d79dcc to 609913cCompareFebruary 22, 2024 14:21
    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/unique-slug@2.0.2
    @SocketSecurity ignore npm/find-cache-dir@1.0.0
    

    new author ok

    @legobeatlegobeat mentioned this pull request Oct 21, 2024
    Merged
    @legobeat

    Copy link
    Copy Markdown
    Author
    @SocketSecurity ignore npm/uglify-es@3.3.9
    @SocketSecurity ignore npm/serialize-javascript@1.9.1
    @SocketSecurity ignore npm/copy-concurrently@1.0.5
    @SocketSecurity ignore npm/fs-write-stream-atomic@1.0.10
    @SocketSecurity ignore npm/move-concurrently@1.0.1
    @SocketSecurity ignore npm/worker-farm@1.7.0
    @SocketSecurity ignore npm/ssri@5.3.0
    

    false positive: only dependency changes is removal of devDependencies.

    @legobeatlegobeat changed the title BREAKING: Disable babelificationDisable babelificationOct 21, 2024
    @legobeat
    legobeat marked this pull request as ready for review October 21, 2024 21:36
    @legobeat
    legobeat requested review from a team and NEllusionOctober 21, 2024 21:40
    @legobeat
    legobeat merged commit de7292f into MetaMask:mainOct 22, 2024
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @legobeat@NEllusion