Skip to content

chore(deps): readable-stream@^2.3.3->^3.6.2 - #39

Closed
legobeat wants to merge 2 commits into
MetaMask:mainfrom
legobeat:deps-readable-stream-3
Closed

chore(deps): readable-stream@^2.3.3->^3.6.2#39
legobeat wants to merge 2 commits into
MetaMask:mainfrom
legobeat:deps-readable-stream-3

Conversation

@legobeat

@legobeatlegobeat commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Blocked by:

@legobeat
legobeat requested a review from a team as a code ownerSeptember 5, 2023 21:15
@legobeat
legobeat requested review from a teamSeptember 5, 2023 21:16
@legobeat
legobeat marked this pull request as draft September 5, 2023 21:18
@socket-security

socket-securityBot commented Sep 5, 2023

Copy link
Copy Markdown

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
end-of-stream1.4.4...1.4.0None+0/-05.8 kBmafintosh
pump1.0.3...2.0.1None+1/-113.2 kBmafintosh
readable-stream2.3.7...3.6.2None+0/-0124 kBmatteo.collina

@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Sep 5, 2023
@legobeatlegobeat mentioned this pull request Sep 5, 2023
Merged
Comment threadpackage.json
"eslint-plugin-prettier": "^3.4.0",
"prettier": "^2.3.0",
"pump": "^1.0.2",
"pump": "^2.0.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legobeat Could we use stream / readable-stream instead?

pump should equal pipeline and end-of-stream should equal finished

https://github.com/nodejs/readable-stream/blob/main/lib/stream.js#L100-L103

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node engines update and the readable-stream bump are interdependent so closing this in favor of #41 , where pump and end-of-stream are now removed.

@legobeat

Copy link
Copy Markdown
ContributorAuthor

Closing in favor of:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat@FrederikBolding