Skip to content

readable-stream v3, nodejs v16 - #41

Merged
legobeat merged 16 commits into
MetaMask:mainfrom
legobeat:node-16
Oct 24, 2023
Merged

readable-stream v3, nodejs v16#41
legobeat merged 16 commits into
MetaMask:mainfrom
legobeat:node-16

Conversation

@legobeat

@legobeatlegobeat commented Sep 5, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • BREAKING: Increase minimum Node.js version from 12 to 16
    • ci: Run on Node.js v18,20 instead of 12,14
    • Change recommended Node.js version to 18
  • BREAKING: deps: readable-stream@^2.3.3->^3.6.2
    • deps: replace end-of-stream with port in readable-stream
    • devDeps: replace pump with port in readable-stream

@legobeat
legobeat requested a review from a team as a code ownerSeptember 5, 2023 21:46
This was referenced Sep 5, 2023
Merged
Closed
@socket-security

socket-securityBot commented Sep 5, 2023•
edited
Loading

Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
readable-stream3.6.2None+0124 kBmatteo.collina
@types/readable-stream2.3.9...4.0.0None+1/-23.92 MBtypes
@types/node14.14.9...20.7.1None+0/-03.89 MBtypes

🚮 Removed packages:@types/end-of-stream@1.4.0, end-of-stream@1.4.4, pump@1.0.3, typescript@4.1.2

@legobeatlegobeat mentioned this pull request Sep 5, 2023
Merged
@legobeat
legobeat marked this pull request as draft September 5, 2023 23:08
@socket-security

socket-securityBot commented Sep 28, 2023•
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
legobeatforce-pushed the node-16 branch 3 times, most recently from 67980bb to 53c554aCompareSeptember 28, 2023 03:38
@legobeat
devDeps: @types/readable-stream@^2.3.15->4.0.0
fcbbf1e
We use readable-stream@3 which had no types package published.
Newer versions of @types/readable-stream@4.x cause type issues
@legobeat
deps: replace end-of-stream with readable-stream.finished
27d13c4
@legobeat
devDeps: replace pump with readable-stream.pipeline
0aada39
@legobeatlegobeat added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@legobeatlegobeat changed the title BREAKING: Increase minimum Node.js version to 16; recommended to 18readable-stream v3, nodejs v16Sep 28, 2023
@legobeat
legobeat marked this pull request as ready for review September 28, 2023 04:17
@legobeatlegobeat mentioned this pull request Sep 28, 2023
Closed
@legobeat
legobeat requested review from a team, FrederikBolding and jiexiSeptember 28, 2023 04:19
naugtur
naugtur reviewed Oct 3, 2023
View reviewed changes
Comment threadsrc/readable-stream.d.ts
naugtur
naugtur reviewed Oct 3, 2023
View reviewed changes
Comment threadyarn.lock Outdated
@legobeat
legobeat requested a review from naugturOctober 3, 2023 13:47
@legobeat
legobeat requested a review from a teamOctober 16, 2023 11:36
@legobeat
legobeat requested review from a teamOctober 24, 2023 00:27
kumavis
kumavis reviewed Oct 24, 2023
View reviewed changes
Comment threadtest/index.js
kumavis
kumavis reviewed Oct 24, 2023
View reviewed changes
Comment threadsrc/readable-stream.d.ts Outdated
@legobeat
legobeat requested a review from kumavisOctober 24, 2023 07:21
@legobeat
legobeat merged commit 3eae042 into MetaMask:mainOct 24, 2023
@legobeatlegobeat mentioned this pull request Oct 24, 2023
Merged
2 tasks
@legobeatlegobeat mentioned this pull request May 15, 2024
Draft
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrederikBoldingFrederikBoldingAwaiting requested review from FrederikBolding
@jiexijiexiAwaiting requested review from jiexi
@MrtenzMrtenzAwaiting requested review from Mrtenz
@weizmanweizmanAwaiting requested review from weizman
@danrocdanrocAwaiting requested review from danroc
@rekmarksrekmarksAwaiting requested review from rekmarks
@shanejonasshanejonasAwaiting requested review from shanejonas
@NiranjanaBinoyNiranjanaBinoyAwaiting requested review from NiranjanaBinoy
@naugturnaugturAwaiting requested review from naugtur
1 more reviewer
@kumaviskumaviskumavis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependenciesPull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat@naugtur@kumavis