Uh oh!
There was an error while loading. Please reload this page.
feat: nodejs support - #226
Closed
kumavis wants to merge 13 commits into
Closed
Conversation
Also tidy up various asynchronous operations in base stream classes. These were causing promises returned from the stream multiplexer to fulfill erratically.
Get rid of the `makeChannels()` contrivance in favor of exposing a singular `addChannel()`. Also expose `start()` function in order to enable either "manually" draining channels or using the `drainAll()` method.
Also make `synchronize()` method of duplex streams optional.
Also fix issues in tests following rebase.
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
rekmarksforce-pushed
the
rekm/node-stream
branch
from
December 10, 2024 19:25
7ee93f4 to
9f45fb8Compare4 tasks
rekmarks
commented
Jan 14, 2025
Member
Superseded by #311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: