Skip to content

Add nodejs package - #311

Merged
grypez merged 22 commits into
mainfrom
grypez/nodejs-pkg
Jan 16, 2025
Merged

Add nodejs package#311
grypez merged 22 commits into
mainfrom
grypez/nodejs-pkg

Conversation

@grypez

Copy link
Copy Markdown
Member

Adds the @ocap/nodejs package for running ocap kernel experiments in a nodejs environment.

@grypez
grypezforce-pushed the grypez/nodejs-pkg branch 2 times, most recently from f73b9ef to 1d423e8CompareJanuary 9, 2025 03:51
@socket-security

socket-securityBot commented Jan 9, 2025

Copy link
Copy Markdown

New dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@types/better-sqlite3@7.6.12None09.48 kBtypes
npm/better-sqlite3@11.8.0filesystem Transitive: environment, network+2510.6 MBjoshuawise

View full report↗︎

@socket-security

socket-securityBot commented Jan 9, 2025

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/tunnel-agent@0.6.0, npm/simple-get@4.0.1, npm/negotiator@1.0.0, npm/unique-slug@5.0.0, npm/@npmcli/fs@4.0.0, npm/unique-filename@4.0.0, npm/better-sqlite3@11.8.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

    @grypez
    grypezforce-pushed the grypez/nodejs-pkg branch 3 times, most recently from 1f8775d to e3f5c5fCompareJanuary 9, 2025 05:29
    @grypez

    Copy link
    Copy Markdown
    MemberAuthor

    @SocketSecurity ignore npm/unique-slug@5.0.0
    @SocketSecurity ignore npm/@npmcli/fs@4.0.0
    @SocketSecurity ignore npm/unique-filename@4.0.0

    The new author is npm-cli-ops

    @grypez

    Copy link
    Copy Markdown
    MemberAuthor

    @SocketSecurity ignore npm/simple-get@4.0.1

    Maintainer is the CEO of Socket

    @grypez

    Copy link
    Copy Markdown
    MemberAuthor

    @SocketSecurity ignore npm/tunnel-agent@0.6.0
    @SocketSecurity ignore npm/negotiator@1.0.0

    Warily we accept these risks.

    @grypez
    grypez marked this pull request as ready for review January 9, 2025 16:47
    @grypez
    grypez requested a review from a team as a code ownerJanuary 9, 2025 16:47
    @grypez
    grypezforce-pushed the grypez/nodejs-pkg branch 2 times, most recently from 538b25b to 19c97dcCompareJanuary 9, 2025 16:57
    @grypezgrypez mentioned this pull request Jan 9, 2025
    @grypez
    grypezforce-pushed the grypez/nodejs-pkg branch 3 times, most recently from 34de6d5 to d5424b0CompareJanuary 10, 2025 17:34

    @rekmarksrekmarks left a comment

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Some mostly cosmetic changes I had queued up. Full review pending.

    Comment threadpackages/nodejs/README.md Outdated
    Comment threadpackages/nodejs/package.json Outdated
    Comment threadpackages/nodejs/package.json Outdated
    Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
    @rekmarksrekmarks mentioned this pull request Jan 14, 2025
    3 tasks

    @rekmarksrekmarks left a comment

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    How do you start the Node kernel? I can't get the e2e tests to run.

    Comment threadpackage.json Outdated
    Comment threadpackages/nodejs/scripts/build-sqlite3.sh Outdated
    Comment threadpackages/nodejs/scripts/build-sqlite3.sh
    Comment threadpackages/nodejs/tsconfig.lint.json Outdated
    Comment threadpackages/nodejs/scripts/build-constants.mjs Outdated
    Comment threadpackages/nodejs/test/e2e/kernel-worker.test.ts Outdated
    Comment threadpackages/nodejs/src/vat/inside.ts
    Comment threadpackages/nodejs/src/kernel/kernel-worker.ts Outdated
    Comment threadpackages/nodejs/src/kernel/sqlite-kv-store.ts Outdated
    Comment threadpackages/nodejs/src/kernel/sqlite-kv-store.ts
    @rekmarksrekmarks linked an issue Jan 15, 2025 that may be closed by this pull request
    4 tasks
    @grypez

    Copy link
    Copy Markdown
    MemberAuthor

    @SocketSecurity ignore npm/better-sqlite3@11.8.0

    We want to use better-sqlite3 and its native code capabilities

    @grypez

    Copy link
    Copy Markdown
    MemberAuthor

    How do you start the Node kernel? I can't get the e2e tests to run.

    Added some e2e test docs 9e413e1

    @rekmarksrekmarks left a comment

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good! Just one minor thing

    Comment threadpackages/nodejs/tsconfig.json Outdated
    Comment threadpackages/nodejs/tsconfig.json Outdated

    @rekmarksrekmarks left a comment

    Copy link
    Copy Markdown
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ship it!!

    @grypez
    grypez merged commit 89525ae into mainJan 16, 2025
    @grypez
    grypez deleted the grypez/nodejs-pkg branch January 16, 2025 15:01
    Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @grypez@rekmarks