Uh oh!
There was an error while loading. Please reload this page.
devDeps: typescript@~5.3.3->~5.6.3 - #381
Merged
Merged
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages:npm/typescript@5.3.3 |
This was referenced Oct 18, 2024
legobeatforce-pushed
the
devdeps-typescript
branch
from
October 18, 2024 06:00
711ce29 to
c96ee7aComparelegobeat
marked this pull request as ready for review
October 18, 2024 06:02
8 tasks
mikesposito
approved these changes
Oct 18, 2024
Gudahtt added a commit
that referenced
this pull request
Nov 27, 2024
The `MetaMaskInpageProvider` type was mistakenly typed to require the `jsonRpcStreamName` as a constructor parameter, despite the author clearly intending this to be optional. This type error was fixed. This type error motivated a different bug, which is that validation for `jsonRpcStreamName` was added to `initializeInapgeProvider` in #381, constituting an undocumented breaking change (currently blocking us from updating this package in `metamask-extension`). This validation has been removed now that it's no longer needed. Fixes#389
Gudahtt added a commit
that referenced
this pull request
Nov 27, 2024
* fix: Allow optional `jsonRpcStreamName` for inpage provider The `MetaMaskInpageProvider` type was mistakenly typed to require the `jsonRpcStreamName` as a constructor parameter, despite the author clearly intending this to be optional. This type error was fixed. This type error motivated a different bug, which is that validation for `jsonRpcStreamName` was added to `initializeInapgeProvider` in #381, constituting an undocumented breaking change (currently blocking us from updating this package in `metamask-extension`). This validation has been removed now that it's no longer needed. Fixes#389 * Update test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
referenceto missingsrc/readable-stream.d.ts.https://github.com/MetaMask/snaps/actions/runs/11377787197/job/31652511752?pr=2817#step:5:9
MetaMask/snaps#2817