Skip to content

deps: @metamask/rpc-errors@^6.3.1->^7.0.0 - #2817

Closed
legobeat wants to merge 8 commits into
MetaMask:mainfrom
legobeat:deps-rpc-errors-7
Closed

deps: @metamask/rpc-errors@^6.3.1->^7.0.0#2817
legobeat wants to merge 8 commits into
MetaMask:mainfrom
legobeat:deps-rpc-errors-7

Conversation

@legobeat

@legobeatlegobeat commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Open question

Currently snaps-rpc-methods tests fail because some errors now have the new (old) behavior of not wrapping error messages.

Haven't figured out if there is something else at play as well/instead but looks like at least @metamask/json-rpc-engine calls serializeError with default arguments which are not currently overridable (though that dependency is still on v6 so TBD)

If the above is correct, which of these options are preferred?

  1. Add/rewrite middleware in snaps to handle this
  2. Add constructor option to JsonRpcEngine to allow overriding serializeError options
  3. Rewrite tests in snaps-rpc-methods to accomodate to new defaults

Related

@socket-security

socket-securityBot commented Oct 9, 2024

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

PackageNew capabilitiesTransitivesSizePublisher
npm/@metamask/eth-json-rpc-middleware@15.0.0network+10995 kBmetamaskbot
npm/@metamask/providers@18.1.0None+5691 kBmetamaskbot

🚮 Removed packages:npm/@metamask/eth-json-rpc-middleware@14.0.2, npm/@metamask/providers@17.2.1

View full report↗︎

@legobeatlegobeat mentioned this pull request Oct 9, 2024
@FrederikBolding

Copy link
Copy Markdown
Member

Done in #2853

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat@FrederikBolding