Uh oh!
There was an error while loading. Please reload this page.
deps: @metamask/rpc-errors@^6.3.1->^7.0.0 - #2817
Closed
legobeat wants to merge 8 commits into
Closed
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages:npm/@metamask/eth-json-rpc-middleware@14.0.2, npm/@metamask/providers@17.2.1 |
legobeatforce-pushed
the
deps-rpc-errors-7
branch
from
October 17, 2024 03:25
cf032c4 to
ecce9e8Compare
This was referenced Oct 17, 2024
legobeatforce-pushed
the
deps-rpc-errors-7
branch
from
October 18, 2024 11:22
dfee8bf to
1c12ef1CompareFrederikBolding
commented
Oct 31, 2024
Member
Done in #2853 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/rpc-errorsfrom^6.3.1to^7.0.0shouldPreserveMessagetofalsefor all invocations ofserializeErrorOpen question
Currently
snaps-rpc-methodstests fail because some errors now have the new (old) behavior of not wrapping error messages.Haven't figured out if there is something else at play as well/instead but looks like at least
@metamask/json-rpc-enginecallsserializeErrorwith default arguments which are not currently overridable (though that dependency is still on v6 so TBD)If the above is correct, which of these options are preferred?
JsonRpcEngineto allow overridingserializeErroroptionssnaps-rpc-methodsto accomodate to new defaultsRelated
@metamask/snaps-sdk?