Uh oh!
There was an error while loading. Please reload this page.
fix: blind vote deeplink bug - #335
Merged
Merged
Conversation
Contributor
Caution Review failedThe pull request is closed. WalkthroughImplements deep-link handling across wallet and eVoting apps: adds blind-vote and reveal flows, async deep-link parsing/dispatch in wallet layout, specialized scan-qr handling for blind-vote/reveal, eVoting reveal deep-link creation, session handoff via sessionStorage, and UI updates to drive and respond to reveal requests. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant EV as eVoting Web App
participant DL as Deep Link (w3ds://)
participant WL as Wallet +layout
participant SQ as Wallet /scan-qr
U->>EV: Click "Reveal" (button or scan QR)
EV->>DL: Open w3ds://reveal?pollId={id}
DL->>WL: Launch app with URL
WL->>WL: Parse URL (type=reveal, pollId)
alt Authenticated
WL->>WL: Store deepLinkData (sessionStorage)
WL->>SQ: Navigate to /scan-qr
SQ->>SQ: Set isRevealRequest, revealPollId
else Not authenticated
WL->>WL: Store pendingDeepLink
WL->>WL: Navigate to /login
end
sequenceDiagram
autonumber
actor U as User
participant WL as Wallet +layout
participant SQ as Wallet /scan-qr
participant API as Poll API
Note over WL: Deep link type=sign with payload
WL->>SQ: Route to /scan-qr with data
SQ->>SQ: Decode signing data
alt Blind vote
SQ->>SQ: Set isBlindVotingRequest, clear errors
SQ->>SQ: Prepare signingData with placeholder pollDetails
SQ->>API: Fetch poll details (async)
API-->>SQ: Poll details (success/fail)
SQ->>SQ: Update signingData.pollDetails or set error
SQ->>SQ: Keep drawer state for blind voting
else Regular signing
SQ->>SQ: Open signing modal/drawer
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File ( |
sosweetham
approved these changes
Aug 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
coodos added a commit
that referenced
this pull request
Nov 4, 2025
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit