Uh oh!
There was an error while loading. Please reload this page.
DEVOPS-1131: Use ref_name and add release tag validation in python_deploy_prod.yml - #92
Open
RomFloreani wants to merge 1 commit into
Open
DEVOPS-1131: Use ref_name and add release tag validation in python_deploy_prod.yml#92RomFloreani wants to merge 1 commit into
RomFloreani wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the production Python deploy workflow to derive the release tag from the Git reference (github.ref_name) and adds an early validation step to prevent manual runs from non-tag refs, aligning release publishing behavior with the intended release-tag source.
Changes:
- Removed
workflow_dispatchinputrelease-tagand switched consumers togithub.ref_name. - Added a
validate-release-tagjob to fail fast when manually dispatched from a non-tag ref. - Updated concurrency grouping and downstream reusable workflow inputs to use the resolved tag name.
Suppressed comments (1)
.github/workflows/python_deploy_prod.yml:57
- With
validate-release-taggated to only run onworkflow_dispatch, this job’sif:should also explicitly allowneeds.validate-release-tag.result == 'skipped'forreleaseevents (and still require success forworkflow_dispatch). Otherwise the publish job can be skipped depending on how the validation job is conditioned.
needs: validate-release-tag
if: ${{ github.event_name == 'release' || github.event.inputs.publish-pypi == 'true' }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+27
to
43
| validate-release-tag: | ||
| name: Validate release tag | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: Ensure this run was triggered from a tag | ||
| if: ${{ github.event_name == 'workflow_dispatch' && github.ref_type != 'tag' }} | ||
| env: | ||
| REF_TYPE: ${{ github.ref_type }} | ||
| REF_NAME: ${{ github.ref_name }} | ||
| run: | | ||
| echo "::error::This run was not triggered from a tag (ref_type=$REF_TYPE, ref_name=$REF_NAME). Re-run this workflow selecting the release tag under 'Use workflow from'." | ||
| exit 1 | ||
| call-workflow-conda-release: | ||
| name: Publish production Conda package on JFrog Artifactory | ||
| needs: validate-release-tag | ||
| if: ${{ github.event_name == 'release' || github.event.inputs.publish-conda == 'true' }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVOPS-1131 - python_deploy_prod workflow to use tag from revision: no manual input
Use github.ref_name instead of workflow_dispatch input release-tag, and add a validate-release-tag job to fail fast when the workflow is not run from a tag.
Mirrors the change made in MiraGeoscience/simpeg#167.