Uh oh!
There was an error while loading. Please reload this page.
DEVOPS-1131: Removing the need for a manual release tag - #167
DEVOPS-1131: Removing the need for a manual release tag#167RomFloreani wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the production Python deployment workflow to remove the requirement for manually entering a release tag on workflow_dispatch, by defaulting to the ref tag that triggered the run and adding a guardrail to fail fast when no tag can be determined.
Changes:
- Made
release-tagoptional for manual runs and defaulted the deploy tag togithub.ref_namewhen appropriate. - Added a
validate-release-tagjob to ensure the workflow has a resolvable tag before attempting publication. - Wired both Conda and PyPI reusable-workflow calls to depend on the validation step.
Suppressed comments (4)
.github/workflows/python_deploy_prod.yml:45
publish-condais a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the-can be parsed as an operator).
needs: validate-release-tag
if: ${{ github.event_name == 'release' || github.event.inputs.publish-conda == 'true' }}
.github/workflows/python_deploy_prod.yml:51
release-tagis a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the-can be parsed as an operator).
release-tag: ${{ github.event.release.tag_name || github.event.inputs.release-tag || github.ref_name }}
.github/workflows/python_deploy_prod.yml:58
publish-pypiis a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the-can be parsed as an operator).
needs: validate-release-tag
if: ${{ github.event_name == 'release' || github.event.inputs.publish-pypi == 'true' }}
.github/workflows/python_deploy_prod.yml:65
release-tagis a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the-can be parsed as an operator).
release-tag: ${{ github.event.release.tag_name || github.event.inputs.release-tag || github.ref_name }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
sebhmg
left a comment
There was a problem hiding this comment.
can be simplified further: no manual input of tag name
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
DEVOPS-1131 - python_deploy_prod workflow to use tag from revision: no manual input