Uh oh!
There was an error while loading. Please reload this page.
[UB] Adding configurable timeout for userbuffer and improving error reporting for potential hangs - #757
Merged
Merged
Conversation
shamispforce-pushed
the
topic/ubhang_ce_v2
branch
4 times, most recently
from
April 6, 2024 16:46
d1665c5 to
0c4ded0Compare* Adding verbose error reporting in case of UB hang * Adding CE hang detector * Replacing hard-coded timeout with configurable one Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
ksivaman
commented
Apr 7, 2024
Member
/te-ci pytorch |
Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
ksivaman
commented
Apr 9, 2024
Member
/te-ci pytorch |
Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
shamispforce-pushed
the
topic/ubhang_ce_v2
branch
from
April 12, 2024 13:32
216e749 to
ed76849Compare* Remove cmake check * Remove unused includes Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com>
ksivaman
commented
Apr 16, 2024
Member
/te-ci pytorch |
ksivaman
approved these changes
Apr 17, 2024
ksivaman
commented
Apr 17, 2024
Member
@denera FYI |
vasunvidia pushed a commit
to vasunvidia/TransformerEngine
that referenced
this pull request
May 1, 2024
…eporting for potential hangs (NVIDIA#757) * Improving error reporting and hang detection logic * Adding verbose error reporting in case of UB hang * Adding CE hang detector * Replacing hard-coded timeout with configurable one Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Cleaning up warnings in the code Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Removing unused codes Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Fixing styling issues reported on github Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Addressing lint new line and casting warnings Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Addressing lint warning about the usage of `unsigned long long` Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Removing unused case causing build issues on multi-arch setup Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Post GRDCOPY removal cleanup * Remove cmake check * Remove unused includes Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> --------- Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
pggPL pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
May 23, 2024
…eporting for potential hangs (NVIDIA#757) * Improving error reporting and hang detection logic * Adding verbose error reporting in case of UB hang * Adding CE hang detector * Replacing hard-coded timeout with configurable one Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Cleaning up warnings in the code Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Removing unused codes Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Fixing styling issues reported on github Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Addressing lint new line and casting warnings Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Addressing lint warning about the usage of `unsigned long long` Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Removing unused case causing build issues on multi-arch setup Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> * Post GRDCOPY removal cleanup * Remove cmake check * Remove unused includes Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> --------- Signed-off-by: Pasha (Pavel) Shamis <pasharesearch@gmail.com> Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
vasunvidia added a commit
to vasunvidia/TransformerEngine
that referenced
this pull request
Jun 13, 2024
… error reporting for potential hangs (NVIDIA#757)" This reverts commit 08e5e4b.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is replacement for #741 based on recent changes in the code.
This PR addresses the following issues: