Rework hierarchy levels - #6957
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
davebayer
force-pushed
the
rework_hierarchy
branch
from
December 11, 2025 18:56
285fc8e to
0913bfc
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
2 times, most recently
from
December 11, 2025 19:52
1696934 to
8e96baa
Compare
pciolkosz
reviewed
Dec 12, 2025
davebayer
force-pushed
the
rework_hierarchy
branch
3 times, most recently
from
December 16, 2025 13:49
378f52f to
ee6e83f
Compare
davebayer
marked this pull request as ready for review
December 16, 2025 13:49
davebayer
force-pushed
the
rework_hierarchy
branch
from
December 16, 2025 13:53
ee6e83f to
41d720f
Compare
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
rework_hierarchy
branch
from
December 17, 2025 08:53
4974c84 to
c9abf7b
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
December 17, 2025 11:55
d1d1d7c to
5a5e93f
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
December 17, 2025 14:18
c7176e9 to
f479987
Compare
davebayer
force-pushed
the
rework_hierarchy
branch
from
December 17, 2025 17:55
4acd651 to
000c2eb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pciolkosz
reviewed
Dec 18, 2025
|
|
||
| _CCCL_TEMPLATE(class _Tp2 = _Tp) | ||
| _CCCL_REQUIRES(::cuda::std::is_same_v<_Tp2, signed char>) | ||
| _CCCL_API constexpr operator char3() const noexcept |
Contributor
There was a problem hiding this comment.
we really need all those operators?
Contributor
Author
There was a problem hiding this comment.
Yes, because if I do just conversion operator to __vector_type_t<_Tp, 3>, there are some problems with implicit conversions with older compilers. And because it's only 1 type, I decided to just do it manually.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pciolkosz
approved these changes
Dec 18, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 28m: Pass: 100%/123 | Total: 1d 01h | Max: 1h 27m | Hits: 97%/232760See results here. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin branch/3.2.x
git worktree add -d .worktree/backport-6957-to-branch/3.2.x origin/branch/3.2.x
cd .worktree/backport-6957-to-branch/3.2.x
git switch --create backport-6957-to-branch/3.2.x
git cherry-pick -x 29397ba3bcd6491512e3d39232bb0a6cf934cf08 |
davebayer
added a commit
to davebayer/cccl
that referenced
this pull request
Dec 19, 2025
* Rework hierarchy levels * add missing launches to native cluster level queries * remove dependency on runtime storage --------- Co-authored-by: pciolkosz <pciolkosz@nvidia.com> (cherry picked from commit 29397ba)
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Dec 23, 2025
* Rework hierarchy levels * add missing launches to native cluster level queries * remove dependency on runtime storage --------- Co-authored-by: pciolkosz <pciolkosz@nvidia.com>
bernhardmgruber
pushed a commit
that referenced
this pull request
Dec 27, 2025
* Avoid use of cccl namespace macros in cub (#6844) (cherry picked from commit 1e3b0b4) * Fix `cuda::std::abs` for floating points (cherry picked from commit 76a3ac6) * Rework hierarchy levels (#6957) * Rework hierarchy levels * add missing launches to native cluster level queries * remove dependency on runtime storage --------- Co-authored-by: pciolkosz <pciolkosz@nvidia.com> (cherry picked from commit 29397ba) * Implement internal vector type traits (#6619) (cherry picked from commit b2c826f) --------- Co-authored-by: pciolkosz <pciolkosz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6885