ci: replace single gating check with `wait-for-status-check` [no-ci] by cpcloud · Pull Request #1008 · NVIDIA/cuda-python

cpcloud · 2025-09-22T20:25:55Z

This PR changes our usage of status-check.yml to allow skipping CI when the head commit of PR contains the text
[skip ci].

Our current usage of the wait-for-check action doesn't sense to me.

We have as inputs all the checks that we care about build, test*, docs,
and we only invoke that action when those succeed.

That seems to be no different than running exit 0 against ubuntu-latest and
thus defeats the purpose of using wait-for-checks which is to allow
finer-grained control over what is actually a required check.

In our case, there are cases such as #999 where it doesn't make sense to do
a full build test docs run, but developers are left waiting on an admin to
merge their PR.

Proposal for merging this PR:

Make the previously not required checks actually required in the GitHub UI.
I don't have permissions to do that, so someone other than me needs to do
that.
Merge this PR.
Try out a couple no-op PRs to verify that everything is working.

copy-pr-bot · 2025-09-22T20:25:59Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

leofang · 2025-10-01T00:25:23Z

/ok to test 6563550

cpcloud · 2025-10-01T14:23:39Z

/ok to test

copy-pr-bot · 2025-10-01T14:23:46Z

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

cpcloud · 2025-10-01T14:27:00Z

/ok to test

leofang · 2025-10-01T14:29:19Z

Check job still completes instead of spinning: https://github.com/NVIDIA/cuda-python/actions/runs/18165463144/job/51706593048?pr=1008

cpcloud · 2025-10-01T14:30:58Z

@leofang Can you paste the names of the checks here from the UI? I can't see them because I don't have access.

leofang · 2025-10-01T14:35:53Z

Once we are sure the check job completes the last, we can either adjust the repo setting and then merge, or admin-merge then adjust the repo setting. But we are not there yet. The repo setting is irrelevant of the failure of waiting for dependent jobs here. It is just a workflow bug that we should fix first.

cpcloud · 2025-10-01T14:42:04Z

/ok to test

cpcloud · 2025-10-01T14:43:45Z

/ok to test

cpcloud · 2025-10-01T14:47:01Z

I'm going to try one more alternative to avoid the action entirely.

cpcloud · 2025-10-01T14:47:14Z

I really don't like having to add an arbitrary delay to get this to work.

leofang · 2025-10-01T14:49:21Z

Yeah adding a random delay is flakey. It could proceed to complete when build jobs finish but the test jobs are still being spawned. Not a fan either.

cpcloud · 2025-10-01T15:02:39Z

/ok to test

cpcloud · 2025-10-01T15:04:00Z

/ok to test

cpcloud · 2025-10-01T15:04:40Z

/ok to test

cpcloud · 2025-10-01T15:10:44Z

/ok to test

cpcloud · 2025-10-01T15:18:28Z

/ok to test

cpcloud · 2025-10-01T15:46:36Z

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

The new status check job should be considered passing, because it's skipped, according to that documentation.

I'm try to taking advantage of the fact that skip == success.

cpcloud · 2025-10-01T15:53:29Z

Figured it out: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

cpcloud · 2025-10-01T15:55:13Z

/ok to test

cpcloud · 2025-10-01T15:58:55Z

/ok to test

cpcloud · 2025-10-01T16:00:51Z

@leofang It looks like the push check is somehow different from the check that's waiting. Are push checks separate in the checks UI?

leofang · 2025-10-01T16:03:22Z

I am checking. This is odd because as discussed earlier once a CI job is run, it should appear as a registered job in the repo setting's dropdown menu, but for some reason I had to type the full name explicitly without anything popping out for me to choose.

leofang · 2025-10-01T16:05:35Z

This is what's in the ruleset that Keith set up. I added the last row manually. Nothing is "push"-specific 🤔

leofang · 2025-10-01T16:13:01Z

@cpcloud I think I fixed it. It's just "Check job status" (without "CI"), see the last row:

You can see your new job becomes required now. But, it does not seem to be allowing a green merge button? Is it because I still haven't removed the old check?

cpcloud · 2025-10-01T16:15:27Z

Is it because I still haven't removed the old check?

Yep, that has to be removed before merge is allowed.

leofang · 2025-10-01T16:16:17Z

Let me check quickly. btw we'll need to backport this PR to 12.9.x. Keith applied the same ruleset to all branches.

leofang · 2025-10-01T16:17:26Z

It works now! To avoid race condition I am merging immediately.

cpcloud · 2025-10-01T16:21:57Z

Thanks for the review, much appreciated!

leofang · 2025-10-01T16:26:06Z

Thanks for working this out Phillip!

github-actions · 2025-10-01T16:32:33Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

…#1056) * ci: replace single gating check with vanilla skipping (#1008) * ci: remove docs * ci: add back matrix filter

kkraus14 reviewed Sep 23, 2025
View reviewed changes

Comment thread.github/workflows/ci.yml Outdated

cpcloud force-pushed the avoid-status-checks-with-skip-ci branch from b455cfe to 7a583d3Compare September 23, 2025 20:12

leofang reviewed Sep 25, 2025
View reviewed changes

Comment thread.github/workflows/status-check.yml

cpcloud force-pushed the avoid-status-checks-with-skip-ci branch from 7a583d3 to 6b6844aCompare September 30, 2025 16:36

cpcloud requested review from kkraus14 and leofang September 30, 2025 16:36

leofang reviewed Oct 1, 2025
View reviewed changes

Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml

This comment has been minimized.
Sign in to view

leofang requested changes Oct 1, 2025
View reviewed changes

Comment thread.github/workflows/ci.yml

cpcloud force-pushed the avoid-status-checks-with-skip-ci branch from 6563550 to d1ec467Compare October 1, 2025 14:09

cpcloud marked this pull request as ready for review October 1, 2025 14:23

cpcloud changed the title ~~ci: replace single gating check with wait-for-status-check~~ci: replace single gating check with wait-for-status-check [skip ci]Oct 1, 2025

cpcloud changed the title ~~ci: replace single gating check with wait-for-status-check [skip ci]~~ci: replace single gating check with wait-for-status-check [no-ci]Oct 1, 2025

ci: replace single gating check with vanilla skipping
1685f32

cpcloud force-pushed the avoid-status-checks-with-skip-ci branch from 8203214 to 1685f32Compare October 1, 2025 15:58

leofang approved these changes Oct 1, 2025
View reviewed changes

leofang merged commit 598874c into NVIDIA:mainOct 1, 2025
13 checks passed

cpcloud deleted the avoid-status-checks-with-skip-ci branch October 1, 2025 16:17

leofang assigned cpcloud Oct 1, 2025

leofang added CI/CD CI/CD infrastructure P1 Medium priority - Should do labels Oct 1, 2025

leofang added this to the cuda.core beta 7 milestone Oct 1, 2025

cpcloud added a commit to cpcloud/cuda-python that referenced this pull request Oct 1, 2025
ci: replace single gating check with vanilla skipping (NVIDIA#1008)
4e902b8

cpcloud mentioned this pull request Oct 1, 2025
ci: replace single gating check with vanilla skipping (#1008) [no-ci] #1056
Merged

cpcloud added a commit that referenced this pull request Oct 1, 2025
ci: replace single gating check with vanilla skipping (#1008) [no-ci] (…
cc8f6d6
…#1056) * ci: replace single gating check with vanilla skipping (#1008) * ci: remove docs * ci: add back matrix filter

cpcloud mentioned this pull request Oct 8, 2025
backport ft fix #1111
Closed

leofang mentioned this pull request Feb 1, 2026
Fix CI checks job to detect test failures #1547
Merged
1 task

leofang mentioned this pull request Jun 13, 2026
CI: "Check job status" aggregator passes when build jobs fail (skipped-as-success regression) #2208
Closed

Uh oh!

Conversation

cpcloud commented Sep 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-botBot commented Sep 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

This comment has been minimized.

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

copy-pr-botBot commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

cpcloud commented Oct 1, 2025

Uh oh!

leofang commented Oct 1, 2025

Uh oh!

github-actionsBot commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

cpcloud commented Sep 22, 2025•
edited
Loading