Skip to content

ci: remove spurious free-threading builds - #999

Merged
kkraus14 merged 1 commit into
NVIDIA:mainfrom
cpcloud:remove-spurious-builds
Sep 23, 2025
Merged

ci: remove spurious free-threading builds#999
kkraus14 merged 1 commit into
NVIDIA:mainfrom
cpcloud:remove-spurious-builds

Conversation

@cpcloud

Copy link
Copy Markdown
Contributor

These will not build, so they should be removed

@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Comment threadci/test-matrix.json
@@ -53,11 +53,6 @@
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.0.1", "LOCAL_CTK": "1", "GPU": "l4", "DRIVER": "latest" },
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.9.1", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "latest" },
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.9.1", "LOCAL_CTK": "1", "GPU": "l4", "DRIVER": "latest" },
{ "ARCH": "amd64", "PY_VER": "3.13t", "CUDA_VER": "11.8.0", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "earliest" },

@cpcloudcpcloudSep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are nightly runs that I've removed, and they haven't yet run, so I think this can be merged without testing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't follow #986 before. Is this a correct understanding:

The lines removed here were added accidentally in #986?

What about this "windows""nightly" further down?

 { "ARCH": "amd64", "PY_VER": "3.12", "CUDA_VER": "12.9.1", "LOCAL_CTK": "1", "GPU": "l4", "DRIVER": "latest" },

(That seems to be the only non-13 build left, using free-threading.)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't mean to add the free-threading builds for non-CUDA@13.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, the other line I asked about above was an existing line, it just got the extra comma.

Comment threadci/test-matrix.json
@@ -53,11 +53,6 @@
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.0.1", "LOCAL_CTK": "1", "GPU": "l4", "DRIVER": "latest" },
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.9.1", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "latest" },
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "12.9.1", "LOCAL_CTK": "1", "GPU": "l4", "DRIVER": "latest" },
{ "ARCH": "amd64", "PY_VER": "3.13t", "CUDA_VER": "11.8.0", "LOCAL_CTK": "0", "GPU": "l4", "DRIVER": "earliest" },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, the other line I asked about above was an existing line, it just got the extra comma.

@cpcloud
cpcloudforce-pushed the remove-spurious-builds branch from 5ee871d to dd25e10CompareSeptember 22, 2025 19:07
@cpcloud

Copy link
Copy Markdown
ContributorAuthor

Since these are nightly, I don't think this needs a full test run.

@cpcloud
cpcloud enabled auto-merge (squash) September 22, 2025 19:08
@cpcloud

Copy link
Copy Markdown
ContributorAuthor

@kkraus14 Can you merge this as admin to avoid a test run?

@cpcloud
cpcloudforce-pushed the remove-spurious-builds branch from dd25e10 to 8f7d4fdCompareSeptember 22, 2025 19:42
@kkraus14
kkraus14 merged commit ef58cb5 into NVIDIA:mainSep 23, 2025
1 check passed
@leofangleofang added bug Something isn't working CI/CD CI/CD infrastructure labels Oct 9, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Oct 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingCI/CDCI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cpcloud@rwgk@kkraus14@leofang