Skip to content

[Backport] #1606 & #873 - #1750

Merged
leofang merged 3 commits into
NVIDIA:12.9.xfrom
leofang:backport-1606
Mar 11, 2026
Merged

[Backport] #1606 & #873#1750
leofang merged 3 commits into
NVIDIA:12.9.xfrom
leofang:backport-1606

Conversation

@leofang

@leofangleofang commented Mar 11, 2026

Copy link
Copy Markdown
Member

Backport of #1606 to 12.9.x. Adapted for the 12.9.x branch workflow structure:

  • ci.yml: add tag push triggers (v*, cuda-core-v*, cuda-pathfinder-v*) so setuptools-scm resolves exact release versions from tag refs
  • release.yml: make run-id optional with auto-detection from tag-triggered CI runs via ci/tools/lookup-run-id; add wheel version validation via ci/tools/validate-release-wheels before publishing
  • Add ci/tools/lookup-run-id: finds the successful tag-triggered CI run for a given release tag
  • Add ci/tools/validate-release-wheels: rejects dev/local wheel versions and enforces version match against the release tag
  • release_checklist.yml: add reminder to wait for tag-triggered CI

Also backport #873. Close#1120.

Backport of NVIDIA#1606 to 12.9.x. Adapted for the 12.9.x branch workflow
structure:
- ci.yml: add tag push triggers (v*, cuda-core-v*, cuda-pathfinder-v*)
so setuptools-scm resolves exact release versions from tag refs
- release.yml: make run-id optional with auto-detection from tag-triggered
CI runs via ci/tools/lookup-run-id; add wheel version validation via
ci/tools/validate-release-wheels before publishing
- Add ci/tools/lookup-run-id: finds the successful tag-triggered CI run
for a given release tag
- Add ci/tools/validate-release-wheels: rejects dev/local wheel versions
and enforces version match against the release tag
- release_checklist.yml: add reminder to wait for tag-triggered CI
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sync release-upload.yml to match main by adding run-id and component
inputs and a 'Download and Upload Wheels' step that downloads wheels
via ci/tools/download-wheels, validates them via validate-release-wheels,
and uploads them to the GitHub Release.
Also add the ci/tools/download-wheels helper script (from main) and
wire up release.yml to pass run-id and component to the upload-archive
job.
FixesNVIDIA#1120: the download-wheels script now exists on the backport
branch, so the release-upload workflow no longer fails with
'No such file or directory'.
@leofangleofang self-assigned this Mar 11, 2026
@leofangleofang changed the title [Backport] CI: require tag-triggered artifacts for release uploads (#1606)[Backport] #1606 & #873Mar 11, 2026
@leofangleofang added bug Something isn't working P0 High priority - Must do! CI/CD CI/CD infrastructure labels Mar 11, 2026
@leofang

Copy link
Copy Markdown
MemberAuthor

pre-commit.ci autofix

@leofang
leofang marked this pull request as ready for review March 11, 2026 03:35
@leofang
leofang requested review from cpcloud and rparolinMarch 11, 2026 03:40
@leofang

Copy link
Copy Markdown
MemberAuthor

Thanks, Phillip! Since it’s touching only the release workflows, no test in the CI would cover it and I’ll just admin-merge it, and then try to release 12.9.6 again.

@leofang
leofang merged commit 721fb62 into NVIDIA:12.9.xMar 11, 2026
1 check passed
@leofang
leofang deleted the backport-1606 branch March 11, 2026 04:01
@leofangleofang linked an issue Mar 12, 2026 that may be closed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingCI/CDCI/CD infrastructureP0High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: ./ci/tools/download-wheels does not exist in the backport branch

2 participants

@leofang@cpcloud