Skip to content

CI: Upload wheels to release artifacts and auto-create release drafts - #873

Merged
leofang merged 5 commits into
mainfrom
copilot/fix-742
Aug 21, 2025
Merged

CI: Upload wheels to release artifacts and auto-create release drafts#873
leofang merged 5 commits into
mainfrom
copilot/fix-742

Conversation

CopilotAI commented Aug 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR extends the release workflow to automatically upload wheels to GitHub release artifacts and improves the release UX by auto-creating release drafts, addressing both the backup solution requested in #742 and the workflow enhancement requested in #622.

Changes Made

1. Created Shared Wheel Download Script

Added ci/tools/download-wheels that encapsulates the wheel downloading logic previously inline in release.yml. The script:

  • Supports both individual components (cuda-core, cuda-bindings, etc.) and "all" components
  • Maintains the same filtering logic to exclude cython test artifacts (*-tests patterns)
  • Provides proper error handling and argument validation

2. Extended release-upload.yml Workflow

Enhanced the existing release upload workflow to optionally download and upload wheels:

  • Added optional run-id and component inputs (maintains backward compatibility)
  • Added conditional step that downloads wheels using the shared script and uploads them to GitHub releases
  • Only executes wheel uploading when both optional inputs are provided

3. Refactored release.yml Workflow

Updated the main release workflow to leverage the new functionality:

  • Modified the upload-archive job call to pass run-id and component parameters for wheel archiving
  • Refactored the publish-wheels job to use the shared script instead of duplicated inline logic

4. Auto-create Release Drafts (Issue #622)

Enhanced the release workflow to improve UX by automatically creating release drafts:

  • If a release draft for a given git tag already exists, proceeds normally (preserves existing behavior)
  • If no release draft exists for the given tag, automatically creates one using gh release create --draft
  • Updated workflow description to reflect the new auto-creation capability

Behavior

  • Existing functionality preserved: Source archive uploading continues to work as before
  • New wheel backup: When releasing, wheels are now automatically uploaded to GitHub release artifacts alongside the source archive
  • Improved UX: No longer requires manually creating release drafts before running the workflow
  • Code reuse: Both workflows share the same tested wheel downloading logic, eliminating duplication
  • PyPI publishing unchanged: The existing PyPI/TestPyPI publishing flow continues to work normally

Testing

The implementation includes comprehensive testing:

  • Script functionality validation with mock GitHub Actions artifacts
  • Integration tests verifying workflow input/output consistency
  • YAML syntax validation and shell script linting
  • Backward compatibility verification

This provides the requested backup solution for publicly released wheels and improved release workflow UX while maintaining all existing functionality and following the principle of minimal, surgical changes.

Fixes#742 and addresses #622.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@copy-pr-bot

copy-pr-botBot commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

CopilotAIand others added 2 commits August 20, 2025 19:01
@leofang
Add shared script and update workflows to upload wheels to release ar…
724717e
…tifacts
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
@leofang
Fix script argument validation and add comprehensive tests
6e1c01d
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
CopilotAI changed the title [WIP] CI: Upload wheels to release artifactsCI: Upload wheels to release artifactsAug 20, 2025
CopilotAI requested a review from leofangAugust 20, 2025 19:08
@leofang

leofang commented Aug 20, 2025

Copy link
Copy Markdown
Member

@copilot thanks. Now that you're touching the release workflows, could you also take the opportunity to address #622? The logic should be

  • if a release draft for a given git tag already exists, do nothing (status quo)
  • otherwise, create a release draft (new)

@leofang
Auto-create release draft if none exists for given tag
509d596
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

CopilotAI commented Aug 20, 2025

Copy link
Copy Markdown
ContributorAuthor

@copilot thanks. Now that you're touching the release workflows, could you also take the opportunity to address #622? The logic should be

  • if a release draft for a given git tag already exists, do n...

Implemented auto-creation of release drafts as requested in #622. The release workflow now:

  • Creates a draft release automatically if none exists for the given git tag
  • Preserves existing behavior when a draft already exists
  • Maintains the same validation logic for existing drafts

This improves the UX by eliminating the manual step of creating release drafts before running the workflow. Commit: 509d596

CopilotAI changed the title CI: Upload wheels to release artifactsCI: Upload wheels to release artifacts and auto-create release draftsAug 20, 2025
leofang
leofang requested changes Aug 21, 2025
View reviewed changes
Comment thread.github/workflows/release-upload.yml Outdated
Comment thread.github/workflows/release-upload.yml Outdated
Comment thread.github/workflows/release-upload.yml Outdated
Comment thread.github/workflows/release-upload.yml
@github-project-automationgithub-project-automationBot moved this from Todo to In Progress in CCCLAug 21, 2025
@leofang
Make run-id and component required inputs in release-upload workflow
da82dfe
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
CopilotAI requested a review from leofangAugust 21, 2025 00:47
@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Aug 21, 2025
@leofangleofang linked an issue Aug 21, 2025 that may be closed by this pull request
CI: Auto-create a release draft in the release workflow? #622
Closed
@leofang
leofang marked this pull request as ready for review August 21, 2025 00:50
@leofang
leofang requested a review from cryosAugust 21, 2025 00:51
leofang
leofang approved these changes Aug 21, 2025
View reviewed changes

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll know if this works next time we release!

Comment threadci/tools/download-wheels
@github-project-automationgithub-project-automationBot moved this from In Progress to In Review in CCCLAug 21, 2025
@leofang
leofang merged commit 5fb3fb6 into mainAug 21, 2025
4 checks passed
@leofang
leofang deleted the copilot/fix-742 branch August 21, 2025 01:45
@github-project-automationgithub-project-automationBot moved this from In Review to Done in CCCLAug 21, 2025
@leofangleofang mentioned this pull request Oct 9, 2025
Closed
@leofangleofang mentioned this pull request Mar 11, 2026
Merged
leofang added a commit that referenced this pull request Mar 11, 2026
@leofang@pre-commit-ci
[Backport]#1606&#873(#1750)
721fb62
* ci: require tag-triggered artifacts for release uploads (#1606)
Backport of #1606 to 12.9.x. Adapted for the 12.9.x branch workflow
structure:
- ci.yml: add tag push triggers (v*, cuda-core-v*, cuda-pathfinder-v*)
so setuptools-scm resolves exact release versions from tag refs
- release.yml: make run-id optional with auto-detection from tag-triggered
CI runs via ci/tools/lookup-run-id; add wheel version validation via
ci/tools/validate-release-wheels before publishing
- Add ci/tools/lookup-run-id: finds the successful tag-triggered CI run
for a given release tag
- Add ci/tools/validate-release-wheels: rejects dev/local wheel versions
and enforces version match against the release tag
- release_checklist.yml: add reminder to wait for tag-triggered CI
* ci: sync release-upload.yml with main and add download-wheels script
Sync release-upload.yml to match main by adding run-id and component
inputs and a 'Download and Upload Wheels' step that downloads wheels
via ci/tools/download-wheels, validates them via validate-release-wheels,
and uploads them to the GitHub Release.
Also add the ci/tools/download-wheels helper script (from main) and
wire up release.yml to pass run-id and component to the upload-archive
job.
Fixes#1120: the download-wheels script now exists on the backport
branch, so the release-upload workflow no longer fails with
'No such file or directory'.
* [pre-commit.ci] auto code formatting
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 approved these changes
@cryoscryosAwaiting requested review from cryos
+1 more reviewer
@leofangleofangleofang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Copilot code reviewCopilot

Labels

CI/CDCI/CD infrastructureenhancementAny code-related improvementsP1Medium priority - Should do

Projects

CCCL
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Upload wheels to release artifacts CI: Auto-create a release draft in the release workflow?

3 participants

@leofang@kkraus14