Skip to content

Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test - #2199

Merged
rwgk merged 2 commits into
NVIDIA:mainfrom
rwgk:nvshmem_pin
Jun 11, 2026
Merged

Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test#2199
rwgk merged 2 commits into
NVIDIA:mainfrom
rwgk:nvshmem_pin

Conversation

@rwgk

@rwgkrwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a !=3.7.0 exclusion to the CUDA 12 and CUDA 13 NVSHMEM test dependencies.
  • Keep pathfinder CI from selecting an NVSHMEM package release that does not provide the expected libnvshmem_device.bc file.

@rwgkrwgk added this to the cuda.pathfinder next milestone Jun 11, 2026
@rwgkrwgk self-assigned this Jun 11, 2026
@rwgkrwgk added P0 High priority - Must do! cuda.pathfinder Everything related to the cuda.pathfinder module labels Jun 11, 2026
@copy-pr-bot

copy-pr-botBot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@rwgk
rwgk marked this pull request as ready for review June 11, 2026 17:00
@rwgk
rwgk requested a review from sebergJune 11, 2026 17:00
seberg
seberg approved these changes Jun 11, 2026
View reviewed changes

@sebergseberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, hopefully we have cleared this up one way or another by the time 3.7.1 hits :).

mdboom
mdboom approved these changes Jun 11, 2026
View reviewed changes

@mdboommdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot added the cuda.core Everything related to the cuda.core module label Jun 11, 2026
@rwgk
rwgk enabled auto-merge (squash) June 11, 2026 19:01
@mdboommdboom changed the title Exclude NVSHMEM 3.7.0 from pathfinder test dependenciesExclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter testJun 11, 2026
@rwgk
rwgk merged commit bd2dc6c into NVIDIA:mainJun 11, 2026
104 checks passed
@rwgk
rwgk deleted the nvshmem_pin branch June 11, 2026 19:51
@github-actions

This comment has been minimized.

Sign in to view
@rwgkrwgk mentioned this pull request Jun 11, 2026
Closed
2 tasks
@github-actions

github-actionsBot commented Jun 12, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboommdboommdboom approved these changes
@sebergsebergseberg approved these changes

Assignees

@rwgkrwgk

Labels

cuda.coreEverything related to the cuda.core modulecuda.pathfinderEverything related to the cuda.pathfinder moduleP0High priority - Must do!

Projects

None yet

Milestone

cuda.pathfinder next

Development

Successfully merging this pull request may close these issues.

3 participants

@rwgk@mdboom@seberg