Skip to content

Add arch-specific bitcode file search to cuda.pathfinder - #2201

Closed
benhg wants to merge 8 commits into
NVIDIA:mainfrom
benhg:issue-2200-sm-arch-bitcode
Closed

Add arch-specific bitcode file search to cuda.pathfinder#2201
benhg wants to merge 8 commits into
NVIDIA:mainfrom
benhg:issue-2200-sm-arch-bitcode

Conversation

@benhg

@benhgbenhg commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

Implement #2200. Adds an sm_arch argument to CUDA-Pathfinder's bitcode file search.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actionsgithub-actionsBot added the cuda.pathfinder Everything related to the cuda.pathfinder module label Jun 11, 2026
@benhg
benhg requested a review from rwgkJune 11, 2026 18:51
benhg
benhg commented Jun 11, 2026
View reviewed changes
Comment threadcuda_pathfinder/tests/test_find_bitcode_lib.py Outdated
@benhg
benhgforce-pushed the issue-2200-sm-arch-bitcode branch from d1f8cc6 to f1289ccCompareJune 11, 2026 18:52
benhg
benhg commented Jun 11, 2026
View reviewed changes
Comment threadcuda_pathfinder/tests/test_find_bitcode_lib.py Outdated
@benhg
benhgforce-pushed the issue-2200-sm-arch-bitcode branch from f1289cc to 98ccd6eCompareJune 11, 2026 18:55
@benhgbenhg self-assigned this Jun 11, 2026
@benhgbenhg added this to the cuda.pathfinder next milestone Jun 11, 2026
leofang
leofang reviewed Jun 11, 2026
View reviewed changes
Comment threadcuda_pathfinder/cuda/pathfinder/_static_libs/find_bitcode_lib.py Outdated
@rwgkrwgk added the P0 High priority - Must do! label Jun 11, 2026
rwgk
rwgk reviewed Jun 11, 2026
View reviewed changes
Comment threadcuda_pathfinder/cuda/pathfinder/_static_libs/find_bitcode_lib.py Outdated
attachments.append(f' Directory does not exist: "{dir_path}"')


def _filename_with_sm_arch(filename: str, sm_arch: str) -> str:

@rwgkrwgkJun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small cleanup: switching to fullmatch, compile the SM arch pattern once, and reuse .pattern in the error message. That keeps the validation contract in one place instead of repeating the regex in code and text.

_SM_ARCH_PATTERN=re.compile(r"sm[0-9]+[a-z]?")
def_filename_with_sm_arch(filename: str, sm_arch: str) ->str:
ifnotsm_arch:
returnfilenameifnot_SM_ARCH_PATTERN.fullmatch(sm_arch):
raiseValueError(f"Invalid sm_arch: {sm_arch!r} must match {_SM_ARCH_PATTERN.pattern!r}")
stem, ext=os.path.splitext(filename)
returnf"{stem}_{sm_arch}{ext}"

rwgk
rwgk reviewed Jun 11, 2026
View reviewed changes
Comment threadcuda_pathfinder/cuda/pathfinder/_static_libs/find_bitcode_lib.py Outdated
@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/ok to test 614dead

@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Hi @benhg, I went ahead and added a commit to parametrize the sm_arch_is_keyword_only test, so that we also have it for locate_bitcode_lib. Running the CI now.

rwgk
rwgk approved these changes Jun 11, 2026
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benhg, I'll set this to auto-merge. 🤞

@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Sorry I overlooked before that this PR was behind main. It was missing PR #2199. I clicked the Update branch button and will retrigger the CI.

@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/ok to test bb8643b

@github-actions

github-actionsBot commented Jun 11, 2026

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-2201/

https://nvidia.github.io/cuda-python/pr-preview/pr-2201/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-2201/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-2201/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@rwgk
rwgk marked this pull request as draft June 11, 2026 23:04
@rwgk

rwgk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Converting to draft, so this doesn't get merged accidentally, pending offline nvshmem design/packaging discussions.

@rwgkrwgk mentioned this pull request Jun 16, 2026
Closed
This was referenced Jul 1, 2026
Merged
Open
@rwgkrwgk added the PR review get-together Mark PRs you'd like the team to review at the weekly PR review get-together. label Jul 6, 2026
@benhg

benhg commented Jul 6, 2026

Copy link
Copy Markdown
MemberAuthor

Closing in favor of new approach mentioned in issue #2200

@benhgbenhg closed this Jul 6, 2026
github-actionsBot pushed a commit that referenced this pull request Jul 7, 2026
cuda-python-bot
Clean up PR preview folders for 1 closed/merged PRs
65bfbf5
Removed preview folders for the following PRs:
- PR #2201
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang left review comments
@rwgkrwgkrwgk approved these changes

Assignees

@benhgbenhg

Labels

cuda.pathfinderEverything related to the cuda.pathfinder moduleP0High priority - Must do!PR review get-togetherMark PRs you'd like the team to review at the weekly PR review get-together.

Projects

None yet

Milestone

cuda.pathfinder next

Development

Successfully merging this pull request may close these issues.

3 participants

@benhg@rwgk@leofang