Uh oh!
There was an error while loading. Please reload this page.
Remove run_tests.sh and unexercised CI meta-tests - #2271
Merged
Conversation
Contributor
lijinf2
commented
Jun 26, 2026
ContributorAuthor
/ok to test 7f71780 |
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Jun 27, 2026
Uh oh!
There was an error while loading. Please reload this page.
|
danielfrg added a commit
that referenced
this pull request
Jul 16, 2026
Resolves conflicts caused by concurrent changes on main: - Relicense (#2293) updated SPDX headers on cuda_bindings/examples/*.py and cuda_bindings/cuda/bindings/_example_helpers/*. All of those files were removed on this branch, so main's edits are discarded via git rm. - Bindings-side test_examples.py, cuda_core/examples/pytorch_example.py and cuda_core/tests/example_tests/test_basic_examples.py were removed on this branch; main's edits to them are discarded. - scripts/run_tests.sh was removed on main (#2271); accept the deletion. - ci/tools/run-tests: keep this branch's optional sample-deps install (nvtx, pillow) but pick up main's rename CUDA_VER_MINOR -> TEST_CUDA_MAJOR_MINOR. - Four new texture / GL-interop examples added to cuda_core/examples/ on main (gl_interop_fluid.py, gl_interop_fluid_numba_cuda_mlir.py, gl_interop_mipmap_lod.py, texture_sample.py) are migrated into their own directories under samples/ with README.md and requirements.txt. Added a DISPLAY guard to glInteropFluid and glInteropMipmapLod so they waive with exit code 2 on headless runners, matching glInteropPlasma. - ruff.toml: ignore RUF059 under samples/** (matches the pre-existing ignore for examples/**). - .spdx-ignore: drop the obsolete cuda_bindings/examples/* line. Verified end-to-end: - pixi install -e samples: solves cleanly. - pytest cuda_core/tests/example_tests/test_samples.py: 46 passed, 9 skipped (all legitimate: no DISPLAY, no P2P, sub-Hopper GPU, or intentionally omitted deps), 0 failed. 55 samples collected. - ruff check + format: clean. - toolshed/check_spdx.py: clean on edited files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First step to close#2174
Remove CI helper scripts and meta-tests that are not exercised by pre-merge CI:
scripts/run_tests.shand doc references.ci/tools/tests/test_fetch_ctk_redistrib.pyChecklist