Uh oh!
There was an error while loading. Please reload this page.
Relicense CUDA Bindings and CUDA Python under Apache 2.0 - #2293
Conversation
Signed-off-by: Keith Kraus <keith.j.kraus@gmail.com>
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Keith Kraus <keith.j.kraus@gmail.com>
kkraus14
commented
Jul 2, 2026
/ok to test |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rwgk
commented
Jul 2, 2026
codex found this: Tracked lockfiles still contain old cuda-bindings license metadata, e.g. cuda_bindings/pixi.lock:3035 and cuda_core/pixi.lock:4497. They are excluded from SPDX checks and partly describe old solved/released packages, but they will still show up in repo-wide old-license searches. |
Signed-off-by: Keith Kraus <keith.j.kraus@gmail.com>
rwgk
commented
Jul 2, 2026
I raised issue #2298 after seeing this. Not sure if we want to do anything about it, but I thought it's useful to document clearly what we have at the moment. |
rwgk
commented
Jul 2, 2026
@kkraus14 this branch is out-of-date with main. Do you want to re-trigger the CI with main merged? |
kkraus14
commented
Jul 2, 2026
Does it matter? I think the only non-comment changes are related to some packaging flows with regards to metadata. I don't think we'd gain any more signal vs the green CI we already have? |
rwgk
commented
Jul 2, 2026
I wasn't sure. When I posted the comment, the CI had just triggered, i.e. it was just the right moment to update; but I didn't want to click the Update branch button without asking. I agree it's fine to merge without updating now that the CI is finished already. One small worry: is @mdboom's cybind MR 453 complete and ready for merging as well? — When I ran codex a couple hours ago, it reported that the cython-gen (aka legacy) updates still only came from 452. |
rwgk
commented
Jul 2, 2026
I just noticed, this PR updates the license in all release notes, e.g. In the meantime codex told me that MR 453 also takes care of the cython-gen / legacy changes, but it also found an potential issue that I'll report on the MR. |
rwgk
left a comment
There was a problem hiding this comment.
To be sure there is no drift, please don't merge before:
cybind MR 454 was merged.
The new cybind main was run against this PR.
rwgk
commented
Jul 3, 2026
I ran a local SPDX copyright-year audit over the tracked files, comparing the newest year in each NVIDIA The full audit currently reports 53 mismatch files in the repository. I then intersected those mismatch files with the files changed by this PR, using PR head 86561aa against refreshed Result: PR 2293 changes 260 files, and none of them overlap with the 53 copyright-year mismatch files. (I backed up my script as |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Resolves conflicts caused by concurrent changes on main: - Relicense (#2293) updated SPDX headers on cuda_bindings/examples/*.py and cuda_bindings/cuda/bindings/_example_helpers/*. All of those files were removed on this branch, so main's edits are discarded via git rm. - Bindings-side test_examples.py, cuda_core/examples/pytorch_example.py and cuda_core/tests/example_tests/test_basic_examples.py were removed on this branch; main's edits to them are discarded. - scripts/run_tests.sh was removed on main (#2271); accept the deletion. - ci/tools/run-tests: keep this branch's optional sample-deps install (nvtx, pillow) but pick up main's rename CUDA_VER_MINOR -> TEST_CUDA_MAJOR_MINOR. - Four new texture / GL-interop examples added to cuda_core/examples/ on main (gl_interop_fluid.py, gl_interop_fluid_numba_cuda_mlir.py, gl_interop_mipmap_lod.py, texture_sample.py) are migrated into their own directories under samples/ with README.md and requirements.txt. Added a DISPLAY guard to glInteropFluid and glInteropMipmapLod so they waive with exit code 2 on headless runners, matching glInteropPlasma. - ruff.toml: ignore RUF059 under samples/** (matches the pre-existing ignore for examples/**). - .spdx-ignore: drop the obsolete cuda_bindings/examples/* line. Verified end-to-end: - pixi install -e samples: solves cleanly. - pytest cuda_core/tests/example_tests/test_samples.py: 46 passed, 9 skipped (all legitimate: no DISPLAY, no P2P, sub-Hopper GPU, or intentionally omitted deps), 0 failed. 55 samples collected. - ruff check + format: clean. - toolshed/check_spdx.py: clean on edited files.
What
Dependency
This draft is based on the post-PR-2285 main branch and is blocked on the internal cybind MR.
Validation