Uh oh!
There was an error while loading. Please reload this page.
CI: Fix backport workflow - #395
Merged
Merged
Conversation
Contributor
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
leofang
marked this pull request as draft
January 15, 2025 07:49
Contributor
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
leofang
marked this pull request as ready for review
January 15, 2025 07:57
leofang
commented
Jan 15, 2025
MemberAuthor
/ok to test |
rwgk
approved these changes
Jan 15, 2025
rwgk
left a comment
Contributor
There was a problem hiding this comment.
LGTM — I'm not very familiar with the details here, but the PR description is very clear!
leofang
commented
Jan 15, 2025
MemberAuthor
Thanks, Ralf! Let me merge and monitor if it is indeed fixed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 fixes, both due to me misreading the documentation 😛
conflict_resolutionargument causes a warning because it's an experimental feature of the backport action, and it should not be passed directly as a input argument, but as a part of json.https://github.com/korthout/backport-action#conflict_resolution
to-be-backportedlabel, ex: Document header requirements for Cython users #372 (comment). It turns out thatlabel_patternis meant to be used as a way to find the backport branch (for which we already settarget_branch), not the way I intend it to (add a label to trigger backport upon merge). This is now fixed.