Skip to content

Document header requirements for Cython users - #372

Merged
leofang merged 3 commits into
NVIDIA:mainfrom
vzhurba01:doc-cython-layer-requirements
Jan 15, 2025
Merged

Document header requirements for Cython users#372
leofang merged 3 commits into
NVIDIA:mainfrom
vzhurba01:doc-cython-layer-requirements

Conversation

@vzhurba01

@vzhurba01vzhurba01 commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

close#245

@vzhurba01vzhurba01 added documentation Improvements or additions to documentation P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jan 10, 2025
@vzhurba01vzhurba01 self-assigned this Jan 10, 2025
@copy-pr-bot

copy-pr-botBot commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01

vzhurba01 commented Jan 10, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@vzhurba01
vzhurba01force-pushed the doc-cython-layer-requirements branch from 0627572 to f33051aCompareJanuary 10, 2025 00:32
@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
Member

/ok to test

leofang
leofang reviewed Jan 10, 2025
View reviewed changes
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
keenan-simpson
keenan-simpson reviewed Jan 14, 2025
View reviewed changes

@keenan-simpsonkeenan-simpson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits. I didn't see anything significant that Leo didn't already mention in his review

Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
Comment threadcuda_bindings/docs/source/install.md Outdated
@vzhurba01vzhurba01 mentioned this pull request Jan 14, 2025
Merged
@vzhurba01

vzhurba01 commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@vzhurba01
vzhurba01force-pushed the doc-cython-layer-requirements branch from e4f8509 to 083347cCompareJanuary 15, 2025 00:42
@vzhurba01

vzhurba01 commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang
leofang merged commit ee8d7cd into NVIDIA:mainJan 15, 2025
@github-actions

github-actionsBot commented Jan 15, 2025

Copy link
Copy Markdown

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-372-to-11.8.x origin/11.8.x
cd .worktree/backport-372-to-11.8.x
git switch --create backport-372-to-11.8.x
git cherry-pick -x 0bd559b0d2b6d19cd04e9dd52e20a839ae2967b4 fd60a05b95742c386b75a3c430324849ddd09d23 083347c6d771b74af94629eaa368bec16fae5022

1 similar comment
@github-actions

github-actionsBot commented Jan 15, 2025

Copy link
Copy Markdown

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-372-to-11.8.x origin/11.8.x
cd .worktree/backport-372-to-11.8.x
git switch --create backport-372-to-11.8.x
git cherry-pick -x 0bd559b0d2b6d19cd04e9dd52e20a839ae2967b4 fd60a05b95742c386b75a3c430324849ddd09d23 083347c6d771b74af94629eaa368bec16fae5022

@leofangleofang mentioned this pull request Jan 15, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes
+1 more reviewer
@keenan-simpsonkeenan-simpsonkeenan-simpson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@vzhurba01vzhurba01

Labels

cuda.bindingsEverything related to the cuda.bindings moduledocumentationImprovements or additions to documentationP0High priority - Must do!

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

Document requirements for using bindings at the Cython layer

3 participants

@vzhurba01@leofang@keenan-simpson