Skip to content

Documentation struct getters - #413

Merged
leofang merged 6 commits into
NVIDIA:mainfrom
keenan-simpson:documentation-struct-getters
Jan 24, 2025
Merged

Documentation struct getters#413
leofang merged 6 commits into
NVIDIA:mainfrom
keenan-simpson:documentation-struct-getters

Conversation

@keenan-simpson

@keenan-simpsonkeenan-simpson commented Jan 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Add a note about using the getters and setters directly to avoid implementation details which break common pythonic code patterns

close#262

@copy-pr-bot

copy-pr-botBot commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@keenan-simpsonkeenan-simpson self-assigned this Jan 23, 2025
@keenan-simpsonkeenan-simpson added documentation Improvements or additions to documentation enhancement Any code-related improvements cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! labels Jan 23, 2025
@keenan-simpsonkeenan-simpson linked an issue Jan 23, 2025 that may be closed by this pull request
Document that struct binding getters return a copy of a value and propagating any changes must go through the setter #262
Closed
@keenan-simpson

keenan-simpson commented Jan 23, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@keenan-simpson
keenan-simpson marked this pull request as ready for review January 23, 2025 22:15
@leofang
leofang requested review from rwgk and removed request for leofangJanuary 24, 2025 02:10
rwgk
rwgk reviewed Jan 24, 2025
View reviewed changes
Comment threadcuda_bindings/docs/source/tips_and_tricks.rst Outdated
@keenan-simpson

keenan-simpson commented Jan 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

rwgk
rwgk previously approved these changes Jan 24, 2025
View reviewed changes
Comment threadcuda_bindings/docs/source/tips_and_tricks.rst Outdated
Comment threadcuda_bindings/docs/source/tips_and_tricks.rst Outdated
Comment threadcuda_bindings/docs/source/tips_and_tricks.rst Outdated
@leofang

leofang commented Jan 24, 2025

Copy link
Copy Markdown
Member

Admin-merge during release meeting, proceed to #366.

@leofang
leofang merged commit cf9d560 into NVIDIA:mainJan 24, 2025
@github-actions

github-actionsBot commented Jan 24, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang approved these changes
@rwgkrwgkrwgk left review comments
@vzhurba01vzhurba01Awaiting requested review from vzhurba01

Assignees

@keenan-simpsonkeenan-simpson

Labels

cuda.bindingsEverything related to the cuda.bindings moduledocumentationImprovements or additions to documentationenhancementAny code-related improvementsP0High priority - Must do!

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

Document that struct binding getters return a copy of a value and propagating any changes must go through the setter

3 participants

@keenan-simpson@leofang@rwgk