Skip to content

Doc updates for 12.8 - #366

Merged
leofang merged 8 commits into
NVIDIA:mainfrom
vzhurba01:12-next-docs
Jan 24, 2025
Merged

Doc updates for 12.8#366
leofang merged 8 commits into
NVIDIA:mainfrom
vzhurba01:12-next-docs

Conversation

@vzhurba01

@vzhurba01vzhurba01 commented Jan 8, 2025•
edited by leofang
Loading

Copy link
Copy Markdown
Contributor

@vzhurba01vzhurba01 added documentation Improvements or additions to documentation cuda.bindings Everything related to the cuda.bindings module labels Jan 8, 2025
@vzhurba01vzhurba01 self-assigned this Jan 8, 2025
@copy-pr-bot

copy-pr-botBot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01vzhurba01 mentioned this pull request Jan 8, 2025
Merged
@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
Member

Q: is this still a draft?

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
Member

We will need to add a release note for 11.8.6 too, to cover #369.

@vzhurba01

vzhurba01 commented Jan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

I'm considering keeping this as a draft until all documentation issues are complete. Perhaps having this PR instead act as a collection of 12-next exclusive documentation updates that can't be merged until release. Right now it's just the optional dependencies, but there might be more after I go through some of my current documentation tasks.

@leofangleofang mentioned this pull request Jan 10, 2025
Merged
@vzhurba01
vzhurba01 marked this pull request as draft January 10, 2025 19:41
@vzhurba01vzhurba01 changed the title Draft: Add PYPI optional dependencies installation instructionsAdd PYPI optional dependencies installation instructionsJan 10, 2025
@vzhurba01

vzhurba01 commented Jan 14, 2025

Copy link
Copy Markdown
ContributorAuthor

TODO: Apply #372 (comment) to this PR talking about [all] and update PR to represent the post-release documentation changes.

@leofangleofang self-assigned this Jan 24, 2025
@leofangleofang changed the title Add PYPI optional dependencies installation instructionsDoc updates for 12.8Jan 24, 2025
@leofangleofang mentioned this pull request Jan 24, 2025
Closed
@leofang

leofang commented Jan 24, 2025

Copy link
Copy Markdown
Member

/ok to test

@leofangleofang mentioned this pull request Jan 24, 2025
Merged
@leofang
leofang marked this pull request as ready for review January 24, 2025 18:24
@leofang

leofang commented Jan 24, 2025

Copy link
Copy Markdown
Member

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@leofang
3 fixes
44f3c3e
- fix support page rendering
- fix relative url
- add 11.8.6 cuda-python nodes
@leofang
leofang requested a review from rwgkJanuary 24, 2025 19:41
leofang
leofang reviewed Jan 24, 2025
View reviewed changes
Comment threadcuda_python/docs/source/release.md
rwgk
rwgk approved these changes Jan 24, 2025
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — I didn't do local testing.

@leofang

leofang commented Jan 24, 2025

Copy link
Copy Markdown
Member

admin-merge to trigger a build in the main branch

@leofang
leofang merged commit c04025d into NVIDIA:mainJan 24, 2025
@github-actions

github-actionsBot commented Jan 24, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofangleofangleofang left review comments
@rwgkrwgkrwgk approved these changes
+1 more reviewer
@keenan-simpsonkeenan-simpsonkeenan-simpson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

@vzhurba01vzhurba01

Labels

cuda.bindingsEverything related to the cuda.bindings moduledocumentationImprovements or additions to documentation

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

Document the expectation of Python object lifetime for binding users Document support policies

4 participants

@vzhurba01@leofang@rwgk@keenan-simpson