Refactor the CI matrix by cryos · Pull Request #555 · NVIDIA/cuda-python

cryos · 2025-04-10T20:28:44Z

Description

Refactor the CI matrix - closes#576.

Refactor the way the CI matrix is composed to be layered, add proxy cache to improve Python package download times, offer a concept of pull request and nightly matrix for the tests.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2025-04-10T20:28:47Z

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

copy-pr-bot · 2025-04-10T20:29:22Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

cryos · 2025-04-10T20:30:34Z

/ok to test

cryos · 2025-04-10T20:34:08Z

/ok to test

cryos · 2025-04-10T20:37:14Z

/ok to test

cryos · 2025-04-10T23:52:55Z

/ok to test

cryos · 2025-04-11T00:04:52Z

/ok to test

cryos · 2025-04-11T00:27:08Z

/ok to test

cryos · 2025-04-11T16:24:08Z

/ok to test a8238f2

cryos · 2025-04-11T16:29:03Z

/ok to test 3097f67

cryos · 2025-04-11T16:38:47Z

/ok to test 3fff795

cryos · 2025-04-17T18:09:48Z

/ok to test

cryos · 2025-04-17T18:13:43Z

/ok to test

cryos · 2025-04-17T18:19:22Z

/ok to test

Also fix the conditional install of git for windows based on local CTK.

cryos · 2025-05-05T19:42:23Z

/ok to test

This is replaced by `ci.yml`.

cryos · 2025-05-06T01:20:11Z

/ok to test

leofang

LGTM! Please hold off merging until we push out 12.9.0 wheels later today 🤞

cryos · 2025-05-06T15:20:57Z

/ok to test

Also pin actions to SHAs (skip ilammy/msvc-dev-cmd for now awaiting update to the allow list).

cryos · 2025-05-06T20:41:24Z

/ok to test

cryos · 2025-05-06T21:23:13Z

/ok to test

leofang · 2025-05-07T01:59:06Z

FYI, we've done GitHub & PyPI releases, so feel free to merge anytime!

leofang · 2025-05-07T12:50:33Z

Many thanks, Marcus! Nice refactoring!!

cryos · 2025-05-07T12:52:05Z

Many thanks, Marcus! Nice refactoring!!

Thanks Leo - more to come but it is good to land this and verify everything looks good.

github-actions · 2025-05-07T13:07:45Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

cryos marked this pull request as draft April 10, 2025 20:29

cryos force-pushed the refactor-ci branch from 6cee1ea to 9cac84cCompare April 10, 2025 20:33

cryos force-pushed the refactor-ci branch from 9cac84c to aa6b208Compare April 10, 2025 20:37

cryos force-pushed the refactor-ci branch from aa6b208 to 8ee06eeCompare April 10, 2025 23:51

cryos added the CI/CD CI/CD infrastructure label Apr 10, 2025

cryos force-pushed the refactor-ci branch from 8ee06ee to a0ba8baCompare April 11, 2025 00:04

cryos force-pushed the refactor-ci branch from a0ba8ba to b903988Compare April 11, 2025 00:26

cryos force-pushed the refactor-ci branch from b903988 to a8238f2Compare April 11, 2025 16:23

cryos force-pushed the refactor-ci branch from 3097f67 to 3fff795Compare April 11, 2025 16:38

leofang self-requested a review April 17, 2025 05:48

leofang assigned cryos Apr 17, 2025

leofang added the P1 Medium priority - Should do label Apr 17, 2025

leofang reviewed Apr 17, 2025
View reviewed changes

Comment thread.github/workflows/build.yml

cryos force-pushed the refactor-ci branch from 1422c86 to d8a6dd0Compare April 17, 2025 18:13

cryos force-pushed the refactor-ci branch from d8a6dd0 to bcffdb5Compare April 17, 2025 18:19

cryos force-pushed the refactor-ci branch from bcffdb5 to 965e7a1Compare April 17, 2025 18:40

12.0.1 won't with with CUDA 11.x drivers
ab1a327
Also fix the conditional install of git for windows based on local CTK.

Remove build-and-test.yml
2e811f3
This is replaced by `ci.yml`.

kkraus14 reviewed May 6, 2025
View reviewed changes

cryos requested a review from kkraus14 May 6, 2025 14:38

leofang previously approved these changes May 6, 2025
View reviewed changes

kkraus14 previously approved these changes May 6, 2025
View reviewed changes

Make cuda-verion required, add missing copright/license
c5eb72c
Also pin actions to SHAs (skip ilammy/msvc-dev-cmd for now awaiting update to the allow list).

cryos dismissed stale reviews from kkraus14 and leofang via 4234124May 6, 2025 20:41

cryos force-pushed the refactor-ci branch from eeaf9c2 to 4234124Compare May 6, 2025 20:41

Move the build and tests to CUDA 12.9.0
959321a

cryos force-pushed the refactor-ci branch from 4234124 to 959321aCompare May 6, 2025 21:22

cryos requested a review from leofang May 6, 2025 22:40

leofang approved these changes May 7, 2025
View reviewed changes

leofang added the enhancement Any code-related improvements label May 7, 2025

cryos merged commit b1085ca into NVIDIA:mainMay 7, 2025

cryos mentioned this pull request May 7, 2025
CI: Reference workflow file name for old branch #620
Merged
3 tasks

leofang added this to the cuda.core beta 4 milestone May 30, 2025

leofang mentioned this pull request Jul 2, 2025
Move pathfinder to cuda-python top level #723
Merged

leofang mentioned this pull request Aug 6, 2025
CI: Enable the proxy cache in test pipelines #812
Closed

CopilotAI mentioned this pull request Aug 20, 2025
CI: Enable proxy cache in test and build-docs pipelines #872
Merged

Uh oh!

Conversation

cryos commented Apr 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

copy-pr-botBot commented Apr 10, 2025

Uh oh!

copy-pr-botBot commented Apr 10, 2025

Uh oh!

cryos commented Apr 10, 2025

Uh oh!

cryos commented Apr 10, 2025

Uh oh!

cryos commented Apr 10, 2025

Uh oh!

cryos commented Apr 10, 2025

Uh oh!

cryos commented Apr 11, 2025

Uh oh!

cryos commented Apr 11, 2025

Uh oh!

cryos commented Apr 11, 2025

Uh oh!

cryos commented Apr 11, 2025

Uh oh!

cryos commented Apr 11, 2025

Uh oh!

Uh oh!

cryos commented Apr 17, 2025

Uh oh!

cryos commented Apr 17, 2025

Uh oh!

cryos commented Apr 17, 2025

Uh oh!

cryos commented May 5, 2025

Uh oh!

cryos commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

cryos commented May 6, 2025

Uh oh!

cryos commented May 6, 2025

Uh oh!

cryos commented May 6, 2025

Uh oh!

leofang commented May 7, 2025

Uh oh!

leofang commented May 7, 2025

Uh oh!

cryos commented May 7, 2025

Uh oh!

github-actionsBot commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cryos commented Apr 10, 2025•
edited
Loading