Skip to content

CI: Reference workflow file name for old branch - #620

Merged
cryos merged 1 commit into
NVIDIA:mainfrom
cryos:ci-reference-11-8-x
May 7, 2025
Merged

CI: Reference workflow file name for old branch#620
cryos merged 1 commit into
NVIDIA:mainfrom
cryos:ci-reference-11-8-x

Conversation

@cryos

@cryoscryos commented May 7, 2025

Copy link
Copy Markdown
Collaborator

Description

Switch to use the workflow file name as the name is getting missed in the merged code in main. Verified the behavior locally too. This is a follow up from #555 addressing an issue seen after merging.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Switch to use the workflow file name as the name is getting missed in
the merged code in main. Verified the behavior locally too.
@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cryos

cryos commented May 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/ok to test

@github-actions

This comment has been minimized.

@cryos
cryos requested a review from leofangMay 7, 2025 15:34
@cryos

cryos commented May 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@leofang see failures after merge where the workflow name is not found. In general I have used workflow file names and they have been reliable.

@leofangleofang added bug Something isn't working P0 High priority - Must do! CI/CD CI/CD infrastructure labels May 7, 2025
@leofangleofang added this to the cuda-python parking lot milestone May 7, 2025

@leofangleofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marcus! Yes, I noticed the main failed too. So instead of backporting the CI name change, we just fix it by referring to the workflow filename. (I did not know this works!) The only catch is that when the current main branch becomes the backport branch in the future, we'll need to change it to ci.yaml.

@leofang

Copy link
Copy Markdown
Member

One question: Why didn't we observe this failure in #555?

@cryos

cryos commented May 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

One question: Why didn't we observe this failure in #555?

Not clear and that is frustrating! I guess we hit a corner case, I will merge this and see if it is more reliable.

@cryos

cryos commented May 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Thanks, Marcus! Yes, I noticed the main failed too. So instead of backporting the CI name change, we just fix it by referring to the workflow filename. (I did not know this works!) The only catch is that when the current main branch becomes the backport branch in the future, we'll need to change it to ci.yaml.

Yes, and I think I will have factored out some of this common code into helper scripts better by that point too.

@cryos
cryos merged commit ee6b92e into NVIDIA:mainMay 7, 2025
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingCI/CDCI/CD infrastructureP0High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cryos@leofang