Uh oh!
There was an error while loading. Please reload this page.
CI: Reference workflow file name for old branch - #620
Conversation
Switch to use the workflow file name as the name is getting missed in the merged code in main. Verified the behavior locally too.
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cryos
commented
May 7, 2025
/ok to test |
This comment has been minimized.
This comment has been minimized.
cryos
commented
May 7, 2025
@leofang see failures after merge where the workflow name is not found. In general I have used workflow file names and they have been reliable. |
leofang
left a comment
There was a problem hiding this comment.
Thanks, Marcus! Yes, I noticed the main failed too. So instead of backporting the CI name change, we just fix it by referring to the workflow filename. (I did not know this works!) The only catch is that when the current main branch becomes the backport branch in the future, we'll need to change it to ci.yaml.
leofang
commented
May 7, 2025
One question: Why didn't we observe this failure in #555? |
cryos
commented
May 7, 2025
Not clear and that is frustrating! I guess we hit a corner case, I will merge this and see if it is more reliable. |
cryos
commented
May 7, 2025
Yes, and I think I will have factored out some of this common code into helper scripts better by that point too. |
|
Description
Switch to use the workflow file name as the name is getting missed in the merged code in main. Verified the behavior locally too. This is a follow up from #555 addressing an issue seen after merging.
Checklist