Uh oh!
There was an error while loading. Please reload this page.
PyTorch example - #579
Conversation
leofang
commented
Apr 26, 2025
Many thanks to your contributions, @msaroufim! 🙏 Please give us a bit of time to unblock you -- This repository, including |
msaroufim
commented
Apr 26, 2025
No worries @leofang I understand, great repo! So looking forward to contributing more soon! |
msaroufim
commented
Apr 29, 2025
@leofang is this ready for a review? FWIW this is the PR I'm most interested in of the 3 I sent |
kkraus14
commented
Apr 29, 2025
@msaroufim apologies for the delay in reviewing this. The examples are run as part of the test suite so I think we need to add pytorch to the test dependencies: the And then also modify the test utilities to properly skip if torch isn't installed in the environment: |
Thanks @kkraus14 mind kicking off a test run for me please? |
msaroufim
commented
Apr 29, 2025
/ok to test 1378e6a |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The testing runs on infrastructure that requires an NVIDIA maintainer to trigger. |
kkraus14
commented
Apr 29, 2025
/ok to test 1378e6a |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
This comment has been minimized.
This comment has been minimized.
kkraus14
commented
Apr 29, 2025
/ok to test 01ad808 |
leofang
left a comment
There was a problem hiding this comment.
Great addition, thanks @msaroufim! I'll add another StridedMemoryView based example later (after #150 is done) and it will also be able to handle PyTorch tensors too, without users fetching the pointer as kernel arg. Will ping you for review.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
msaroufim
commented
Apr 29, 2025
Regarding the testing changes @leofang please feel free to revert depending on what makes sense to you, I just tested your changes now locally and everything worked well |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
Apr 29, 2025
/ok to test 7d3582f |
|
Description
This PR provides an end to end example of integrating PyTorch with cuda-python. In particular this PR
Limitation
Example of running this locally
Checklist