Uh oh!
There was an error while loading. Please reload this page.
Change cuda.core license to Apache-2.0 & make contributing guides clear - #583
Conversation
leofang
commented
Apr 25, 2025
/ok to test 3978a2f |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
Apr 26, 2025
/ok to test 58c6f9d |
leofang
commented
Apr 26, 2025
/ok to test 05b63d2 |
leofang
commented
Apr 26, 2025
/ok to test 15525a7 |
leofang
commented
Apr 26, 2025
rwgk
commented
Apr 26, 2025
LGTM based on what I see under GH "Files changed" I had the idea to look at the doc preview: In Under https://nvidia.github.io/cuda-python/cuda-bindings/latest/ I only see the first 8 items in the side bar, the last 3 are not there. Is that intentional? It's the same already under https://nvidia.github.io/cuda-python/cuda-bindings/ I.e. without |
I am sure we discussed this 😛 the latest docs is updated after a PR is merged into main, not before. AFAIK this is universal behavior with respect to e.g. Read the Docs too. This is why we set up the doc preview CI: #583 (comment) |
rwgk
commented
Apr 26, 2025
Oh, I thought I used that link! — I must have fallen off the track when clicking around. Sorry. |
leofang
commented
Apr 26, 2025
No worries at all! There exists a few rough edges in the doc preview I am not happy about, that could lead to what you observed. For example, in some of the places we hard-wire the urls that point to latest. Also because we stitch all the component docs together, the cross links do not respect the url change (having pr-XXX as part of the url). This is why the CI message needs to leave 3 urls instead of 1 🥲 some love is needed for improving it... |
rwgk
commented
Apr 26, 2025
Do we need/want |
leofang
commented
Apr 26, 2025
I removed it because of #234, but I could use some second opinions here 🙂Let me know what you think... |
rwgk
commented
Apr 26, 2025
rwgk
commented
Apr 26, 2025
Got it, thanks! — I don't have an opinion. Only this much: Might be nice to have for completeness, but not sure if it's worth anyone's time. |
leofang
commented
Apr 26, 2025
Yes, this comes from our own html hack to enable the hidden version selector capability. I opened #587. |
kkraus14
left a comment
There was a problem hiding this comment.
We need SPDX identifiers on all of the files in .github as well as the top level config files like pre-commit and bandit configs.
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
Apr 28, 2025
/ok to test ee1dc0a |
leofang
commented
Apr 28, 2025
Merging since both Andy and Keith approved and Ralf also helped review. Thanks guys! |
|

Description
Close#533. Close#234.
We implement a short-term solution that retains the NV Software License only to files under
cuda_bindings/andcuda_python/, and change to Apache 2 forcuda_core/and other files in this repository (ex: helper scripts, CI workflows, ...). Long-term solution regarding the multi-license issue in the repo is TBD.Checklist