Skip to content

Pre commit fixes - #911

Merged
leofang merged 3 commits into
NVIDIA:mainfrom
rwgk:pre-commit-fixes
Aug 27, 2025
Merged

Pre commit fixes#911
leofang merged 3 commits into
NVIDIA:mainfrom
rwgk:pre-commit-fixes

Conversation

@rwgk

@rwgkrwgk commented Aug 27, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Three tiny unrelated small fixes:

rwgk added 3 commits August 27, 2025 09:01
@rwgk
Define gen_exclude anchor at first use to resolve warning
d12b9e0
This was the warning:
[WARNING] Unexpected key(s) present at root: gen_exclude
Also fix the regex: the old pattern was missing the ^ before the second alternative
@rwgk
Remove requirements-txt-fixer
240d637
To avoid this line:
```
fix requirements.txt.................................(no files to check)Skipped
```
@rwgk
Change the commit hash in .github/workflows/bandit.yml
ed25cc7
@copy-pr-bot

copy-pr-botBot commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang

leofang commented Aug 27, 2025

Copy link
Copy Markdown
Member

/ok to test

@leofangleofang added bug Something isn't working P0 High priority - Must do! CI/CD CI/CD infrastructure labels Aug 27, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Aug 27, 2025
@leofang
leofang enabled auto-merge (squash) August 27, 2025 16:47
@github-actions

This comment has been minimized.

Sign in to view
kkraus14
kkraus14 reviewed Aug 27, 2025
View reviewed changes
Comment thread.github/workflows/bandit.yml
steps:
- name: Perform Bandit Analysis
uses: PyCQA/bandit-action@67a458d90fa11fb1463e91e7f4c8f068b5863c7f # v1.0.1
uses: PyCQA/bandit-action@8a1b30610f61f3f792fe7556e888c9d7dffa52de

@kkraus14kkraus14Aug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this associated with a specific tag?

@leofangleofangAug 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from a copy/paste from the global allowlist. At this point I am not sure it makes sense for us to dig out the corresponding version if we don't own the version bump?

@kkraus14kkraus14Aug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit tied to v1.0.0 where this would be a downgrade that also includes running on Python 3.8 which is EOL.

@rwgkrwgkAug 27, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the workflow runs with this, which seems like a strict improvement for the minute.

I want to propose to work on it more in a follow-on PR. In the meantime I figured out a simple approach to keep the workflow and pre-commit in sync (manually).

But should I add the # v1.0.0 comment here? (I missed that before.)

(Then you could admin merge.)

@kkraus14kkraus14Aug 27, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess let's add the comment for v1.0.0 here for now and then upgrade it once things are fixed at the org level

@leofang
leofang merged commit 333367e into NVIDIA:mainAug 27, 2025
52 checks passed
@rwgk

rwgk commented Aug 27, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ugh, I was a second too slow, disabling the auto-merge. Sorry.

@rwgk
rwgk deleted the pre-commit-fixes branch August 27, 2025 17:55
@kkraus14

kkraus14 commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator

No worries, this should hopefully be very temporarily short-lived

@github-actions

github-actionsBot commented Aug 27, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

This was referenced Aug 28, 2025
Merged
Closed
@rwgkrwgk mentioned this pull request Sep 25, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 left review comments
@leofangleofangleofang approved these changes

Assignees

@rwgkrwgk

Labels

bugSomething isn't workingCI/CDCI/CD infrastructureP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

3 participants

@rwgk@leofang@kkraus14