Skip to content

main: Fix broken links in 3.2.0.md - #4979

Merged
lornajane merged 2 commits into
mainfrom
ralfhandl-patch-5
Sep 28, 2025
Merged

main: Fix broken links in 3.2.0.md#4979
lornajane merged 2 commits into
mainfrom
ralfhandl-patch-5

Conversation

@ralfhandl

@ralfhandlralfhandl commented Sep 20, 2025

Copy link
Copy Markdown
Contributor

Fixing this broken link will not make visible changes to the rendered spec and will only avoid a 404 when clicking on the link.

I think this change does not justify a 3.2.1 release and leaving 3.2.0 broken forever.

  • no schema changes are needed for this pull request

@ralfhandl
ralfhandl requested a review from a team as a code ownerSeptember 20, 2025 17:49
handrews
handrews previously approved these changes Sep 20, 2025

@handrewshandrews left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fits with the precedents of having fixed broken links on main manually multiple times in the past, including:

@ralfhandlralfhandl changed the title Hot fix: Repair broken link in 3.2.0.mdHot fix on main: Repair broken link in 3.2.0.mdSep 20, 2025
@ralfhandlralfhandl changed the title Hot fix on main: Repair broken link in 3.2.0.mdmain: Fix broken link in 3.2.0.mdSep 20, 2025
karenetheridge
karenetheridge previously approved these changes Sep 20, 2025
miqui
miqui previously approved these changes Sep 21, 2025
@handrews

Copy link
Copy Markdown
Member

[omg "precedents" not "precedence"... how tired was I when I wrote that? 🤦]

@ralfhandl
ralfhandl marked this pull request as draft September 23, 2025 17:51
@ralfhandl

Copy link
Copy Markdown
ContributorAuthor

More links are broken, see

@ralfhandl
ralfhandl marked this pull request as ready for review September 24, 2025 14:16
@ralfhandl
ralfhandl requested review from a team, handrews and miquiSeptember 24, 2025 14:17
@ralfhandlralfhandl changed the title main: Fix broken link in 3.2.0.mdmain: Fix broken links in 3.2.0.mdSep 24, 2025
@lornajane

Copy link
Copy Markdown
Contributor

I note that the build failure is expected - it is flagging that the edit is to the versions file which we normally don't edit, but this time we are.

@lornajanelornajane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also checked it with a link checking tool!

@lornajane
lornajane merged commit 815732d into mainSep 28, 2025
3 of 4 checks passed
@lornajane
lornajane deleted the ralfhandl-patch-5 branch September 28, 2025 20:27
@ralfhandl

Copy link
Copy Markdown
ContributorAuthor

checked it with a link checking tool

@lornajane Which tool did you use? Can we add it to our markdown linting script?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ralfhandl@handrews@lornajane@karenetheridge@miqui