Skip to content

3.2.1: Fix dead anchor links to appendix - #4987

Merged
ralfhandl merged 1 commit into
OAI:v3.2-devfrom
paulRbr:patch-1
Sep 25, 2025
Merged

3.2.1: Fix dead anchor links to appendix#4987
ralfhandl merged 1 commit into
OAI:v3.2-devfrom
paulRbr:patch-1

Conversation

@paulRbr

@paulRbrpaulRbr commented Sep 23, 2025•
edited
Loading

Copy link
Copy Markdown
  • no schema changes are needed for this pull request

It seems one of the link is fixed in #4980 but targets 3.3-dev, I don't know how the dev process works and how the fixes are backported (the links are probably broken in previous version of OpenAPI and also in the future 3.3 version)

@paulRbr
paulRbr requested review from a team as code ownersSeptember 23, 2025 09:27
@ralfhandl
ralfhandl requested a review from a teamSeptember 23, 2025 09:33
@ralfhandl

ralfhandl commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

@paulRbr Thanks for finding these!

And feel free to create a twin PR targeting v3.3-dev, we don't have an automated forward-port mechanism.

@paulRbrpaulRbr mentioned this pull request Sep 23, 2025
Merged
1 task
@handrews

handrews commented Sep 23, 2025

Copy link
Copy Markdown
Member

@ralfhandl how did this get past the build scripts? I know I've gotten errors on missing # before, for example. Also, does this need to be patched on main like the other broken link?

@lornajane

lornajane commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Markdown lint saw these as valid syntax. I have a link checker on my todo list though!

@ralfhandl

ralfhandl commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Markdown lint saw these as valid syntax

The broken supposedly internal links didn't start with a # and were treated as external links and thus not checked.

A link checker that (also) checks external links would be very helpful.

@ralfhandl

ralfhandl commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Any objections to merging this and its v3.3 twin?

@ralfhandlralfhandl added this to the v3.2.1 milestone Sep 23, 2025
@ralfhandlralfhandl added the editorial Wording and stylistic issues label Sep 23, 2025
@ralfhandlralfhandl mentioned this pull request Sep 23, 2025
Merged
1 task
@ralfhandlralfhandl changed the title Fix dead anchor links to appendix3.2.1: Fix dead anchor links to appendixSep 25, 2025
mikekistler
mikekistler approved these changes Sep 25, 2025
View reviewed changes

@mikekistlermikekistler left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@baywetbaywet mentioned this pull request Sep 25, 2025
Closed
@ralfhandl
ralfhandl merged commit 0847e98 into OAI:v3.2-devSep 25, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenetheridgekarenetheridgekarenetheridge approved these changes
@ralfhandlralfhandlralfhandl approved these changes
@mikekistlermikekistlermikekistler approved these changes

Assignees

No one assigned

Labels

editorialWording and stylistic issues

Projects

None yet

Milestone

v3.2.1

Development

Successfully merging this pull request may close these issues.

6 participants

@paulRbr@ralfhandl@handrews@lornajane@karenetheridge@mikekistler