Skip to content

3.3: schema tests for unevaluatedProperties - #5095

Merged
miqui merged 6 commits into
OAI:v3.3-devfrom
ralfhandl:3.3-test-unevaluatedProperrties
May 7, 2026
Merged

3.3: schema tests for unevaluatedProperties#5095
miqui merged 6 commits into
OAI:v3.3-devfrom
ralfhandl:3.3-test-unevaluatedProperrties

Conversation

@ralfhandl

@ralfhandlralfhandl commented Oct 31, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Many Objects defined in the spec don't allow additional properties.

Test these by taking a minimal instance that passes, inject a property with a very unlikely name and verify that it fails.

  • New "fail" test cases for Discriminator Object and External Documentation Object within a Schema Object, defined in meta.yaml
  • Table-driven test for Objects defined in schema.yaml with test cases in file minimal-objects.yaml

This brings subschema ("function") test coverage up to 100%.

  • no schema changes are needed for this pull request

@ralfhandl
ralfhandl requested review from a team as code ownersOctober 31, 2025 15:59
@ralfhandlralfhandl mentioned this pull request Oct 31, 2025
Closed
1 task
@ralfhandl
ralfhandl requested a review from a teamNovember 3, 2025 07:45
miqui
miqui previously approved these changes Jan 22, 2026
View reviewed changes

@miquimiqui left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@ralfhandl
ralfhandl requested a review from a teamJanuary 25, 2026 10:24
@baywet

baywet commented Feb 26, 2026

Copy link
Copy Markdown
Member

From the meeting: might need a rebase and an additional approval before merge.

karenetheridge
karenetheridge requested changes Feb 26, 2026
View reviewed changes
Comment threadtests/schema/fail/schema-object-externalDocs-unexpected-property.yaml
@karenetheridge

karenetheridge commented Feb 26, 2026

Copy link
Copy Markdown
Member

(I removed a comment here that was invalid -- it was due to an error I had made with processing the 3.2 changes to the discriminator property ;) )

ralfhandland others added 2 commits February 27, 2026 12:19
@ralfhandl
Merge branch 'v3.3-dev' into 3.3-test-unevaluatedProperrties
1fe6a24
@ralfhandl
Refreshed
0cf186d
- updated from base
- fixed typo in fail test case file name
- added new fail test case
@ralfhandl
ralfhandl requested a review from a teamFebruary 28, 2026 16:16
@ralfhandlralfhandl mentioned this pull request Mar 10, 2026
Closed
miqui
miqui previously approved these changes Mar 18, 2026
View reviewed changes
@ralfhandl

ralfhandl commented Apr 16, 2026

Copy link
Copy Markdown
ContributorAuthor

@karenetheridge Would you mind re-reviewing this PR?

karenetheridge
karenetheridge reviewed Apr 16, 2026
View reviewed changes
Comment threadtests/schema/minimal-objects.yaml Outdated
Comment threadtests/schema/minimal-objects.yaml Outdated
Comment threadtests/schema/minimal-objects.yaml Outdated
Comment threadtests/schema/minimal-objects.yaml
@ralfhandl
ralfhandl requested a review from a teamApril 20, 2026 19:01
@ralfhandl

ralfhandl commented May 7, 2026

Copy link
Copy Markdown
ContributorAuthor

@miqui Could you please review & approve again?

@miqui
miqui merged commit ac41085 into OAI:v3.3-devMay 7, 2026
2 checks passed
@ralfhandl
ralfhandl deleted the 3.3-test-unevaluatedProperrties branch May 8, 2026 06:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenetheridgekarenetheridgekarenetheridge approved these changes
@miquimiquimiqui approved these changes
+1 more reviewer
@fred231084gfred231084gfred231084g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ralfhandl@baywet@karenetheridge@miqui@fred231084g