Skip to content

[FIX] base: trans_implied_ids recursive computation - #1306

Merged
thomaspaulb merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-fix-base-trans_implied_groups
Aug 6, 2025
Merged

thomaspaulb merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-fix-base-trans_implied_groups

Conversation

@SirPyTech

Copy link
Copy Markdown

Steps

  1. Install sale module
  2. In the Odoo shell execute: env["res.groups"].get_groups_by_application()

Actual result
[..., (ir.module.category(52,), 'boolean', res.groups(22, 21, 20), (100, 'Other')) , ...]

Expected result
[..., (ir.module.category(52,), 'selection', res.groups(20, 21, 22), (5, 'Sales')) , ...]

Additional info
The result of get_groups_by_application is correct if the computation of res.groups.trans_implied_ids is called executing: env["res.groups"].search([])._compute_trans_implied()

Moved here from OCA/server-tools#3320.
I tried to add a test in sale module but didn't manage to add a test that would fail without this change.

This is already present in 15.0 and following versions of Odoo thanks to odoo@34d6f87.

1. Install `sale` module
2. In the Odoo shell execute: `env["res.groups"].get_groups_by_application()`

*Actual result*
`[...,  (ir.module.category(52,), 'boolean', res.groups(22, 21, 20), (100, 'Other')) , ...]`

*Expected result*
`[...,  (ir.module.category(52,), 'selection', res.groups(20, 21, 22), (5, 'Sales')) , ...]`

*Additional info*
The result of `get_groups_by_application` is correct if the computation of `res.groups.trans_implied_ids` is called executing:
`env["res.groups"].search([])._compute_trans_implied()`
@SirPyTech
SirPyTech marked this pull request as ready for review July 2, 2025 12:56
@SirPyTech

Copy link
Copy Markdown
Author

@thomaspaulb here you go, let me know what you think!

@OCA-git-bot

Copy link
Copy Markdown

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops

Copy link
Copy Markdown

@thomaspaulb can this be merged? thanks!

@thomaspaulb

Copy link
Copy Markdown

/ocabot merge patch

@thomaspaulb

Copy link
Copy Markdown

not sure if I have rights here

@OCA-git-bot

Copy link
Copy Markdown

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1306-by-thomaspaulb-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 9, 2025
Signed-off-by thomaspaulb
@SirPyTech

Copy link
Copy Markdown
Author

not sure if I have rights here

I believe that if you have the green check ✔️ in image
then you can merge

Thanks for merging!

@francesco-ooops

Copy link
Copy Markdown

@thomaspaulb can you please relaunch merge command? thanks!

@thomaspaulb

Copy link
Copy Markdown

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1306-by-thomaspaulb-bump-patch, awaiting test results.

@francesco-ooops

Copy link
Copy Markdown

@gurneyalex any idea why the bot is not completing the merge? thanks!

@francesco-ooops

Copy link
Copy Markdown

@OCA/backport-maintainers could this be tried again?

@thomaspaulb

Copy link
Copy Markdown

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1306-by-thomaspaulb-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 6, 2025
Signed-off-by thomaspaulb
@pedrobaeza

Copy link
Copy Markdown
Member

ocabot is not working in OCB. You have to manually merge.

@thomaspaulb
thomaspaulb merged commit 36288c6 into OCA:14.0 Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants