Skip to content

[ADD] fix_compute_trans_implied_groups - #3320

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-fix-trans_implied_groups
Jan 27, 2026
Merged

[ADD] fix_compute_trans_implied_groups#3320
OCA-git-bot merged 1 commit into
OCA:14.0from
PyTech-SRL:14.0-fix-trans_implied_groups

Conversation

@SirPyTech

Copy link
Copy Markdown

This fix should be in Odoo's 14.0 branch but it's no more maintained, so we have to create a module.
This isn't needed in 16.0 thanks to odoo/odoo@34d6f87.

I haven't added a test in this module because the only way I know to reproduce this bug is to install the sale module and it makes no sense to add such a dependency in this module.

Let me know what you think!

@SirPyTech
SirPyTech marked this pull request as ready for review June 26, 2025 14:32

@GSLabIt GSLabIt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ideally this fix should be added to OCB, but I understand that not everyone uses it.

@francesco-ooops

Copy link
Copy Markdown
Contributor

@OCA/tools-maintainers wdyt?

@thomaspaulb

Copy link
Copy Markdown
Contributor

@SirPyTech For the unit test what you could do is to create a separate _test module which has the test and also depends on sale.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb

Copy link
Copy Markdown
Contributor

Also, can you explain your reason for not using OCB?

@SirPyTech

Copy link
Copy Markdown
Author

Thanks @thomaspaulb for having a look!
I'll try to move this fix to OCB and then maybe I'll be able to add a proper test in sale module 🚀
I didn't use OCB at first because I thought our customer wasn't using it.

@SirPyTech

Copy link
Copy Markdown
Author

Moved to OCA/OCB#1306

@SirPyTech SirPyTech closed this Jul 2, 2025
@SirPyTech

Copy link
Copy Markdown
Author

Reopening to allow non-OCB users to enjoy this fix

@SirPyTech SirPyTech reopened this Jul 9, 2025
@SirPyTech
SirPyTech marked this pull request as ready for review July 9, 2025 14:18
@thomaspaulb

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3320-by-thomaspaulb-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 25, 2026
Signed-off-by thomaspaulb
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@thomaspaulb your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3320-by-thomaspaulb-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@SirPyTech

Copy link
Copy Markdown
Author

/ocabot merge nobump

Thanks @thomaspaulb for trying to merge!
The module letsencrypt is failing a test only in the OCB execution (see https://github.com/OCA/server-tools/actions/runs/21340400922/job/61418864454#step:8:1115), it is probably temporary, please try again 🙏

@thomaspaulb

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3320-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 5000470 into OCA:14.0 Jan 27, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 57b21e9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants