[ADD] fix_compute_trans_implied_groups - #3320
Conversation
HekkiMelody
left a comment
There was a problem hiding this comment.
LGTM.
Ideally this fix should be added to OCB, but I understand that not everyone uses it.
|
@OCA/tools-maintainers wdyt? |
|
@SirPyTech For the unit test what you could do is to create a separate |
|
This PR has the |
|
Also, can you explain your reason for not using OCB? |
|
Thanks @thomaspaulb for having a look! |
|
Moved to OCA/OCB#1306 |
|
Reopening to allow non-OCB users to enjoy this fix |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@thomaspaulb your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3320-by-thomaspaulb-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Thanks @thomaspaulb for trying to merge! |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 57b21e9. Thanks a lot for contributing to OCA. ❤️ |
This fix should be in Odoo's
14.0branch but it's no more maintained, so we have to create a module.This isn't needed in
16.0thanks to odoo/odoo@34d6f87.I haven't added a test in this module because the only way I know to reproduce this bug is to install the
salemodule and it makes no sense to add such a dependency in this module.Let me know what you think!