Skip to content

[8.0][ADD][WIP][event_multi_image] Image gallery for events. - #31

Merged
pedrobaeza merged 1 commit into
OCA:8.0from
yajo:multi-image
Mar 10, 2016
Merged

pedrobaeza merged 1 commit into
OCA:8.0from
yajo:multi-image

Conversation

@yajo

@yajo yajo commented Feb 3, 2016

Copy link
Copy Markdown
Member

This module allows to have multiple images in each event.

It depends on:

@rafaelbn

@dreispt

dreispt commented Feb 8, 2016

Copy link
Copy Markdown
Member

Question: isn't there a product multi-image module? With the feature linking Events to Products there would be no need to have and event-specific multi-image.

@yajo

yajo commented Feb 9, 2016

Copy link
Copy Markdown
Member Author

The event product could be i.e. "Conference", but each conference has its own gallery.

@dreispt

dreispt commented Feb 12, 2016

Copy link
Copy Markdown
Member

OK

Comment thread .travis.yml Outdated
- travis_install_nightly
- pip install python-ldap
- pip install unidecode
- pip install validate_email

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new dependencies?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For product-attribute repo.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. With the new support for requirements.txt on repos this will be unnecessary once the requirements file is added to product-attribute.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that I can remove this now, or that I will can in some near future?

@dreispt

dreispt commented Feb 12, 2016

Copy link
Copy Markdown
Member

Other than the added dependencies, LGTM.

This module allows to have multiple images in each event.
Comment thread oca_dependencies.txt
@@ -1,4 +1,5 @@
# List the OCA project dependencies, one per line
# Add a repository url and branch if you need a forked version
server-tools

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot says:

except_orm: ('Error', u"You try to install module 'event_multi_image' that depends on module 'base_multi_image'.\nBut the latter module is not available in your system.")

That module is in server-tools now. Is it not enough to add it here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is for Travis, but runbot isn't still able to process this. I'm adding it manually

@dreispt

dreispt commented Mar 10, 2016

Copy link
Copy Markdown
Member

LGTM 👍

@pedrobaeza

Copy link
Copy Markdown
Member

👍

pedrobaeza added a commit that referenced this pull request Mar 10, 2016
[8.0][ADD][WIP][event_multi_image] Image gallery for events.
@pedrobaeza
pedrobaeza merged commit 8ed22e1 into OCA:8.0 Mar 10, 2016
@yajo
yajo deleted the multi-image branch March 11, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants